Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313376

Summary: TVT36:TCT288: FRA - Unnecessary mnemonic under Class in API Compatibility
Product: [Eclipse Project] PDE Reporter: CDE Administration <cdeadmin>
Component: API ToolsAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: camle, daniel_megert, darin.eclipse, kitlo, Michael_Rennie, Olivier_Thomann, pwebster
Version: 3.6Flags: Michael_Rennie: review+
darin.eclipse: review+
daniel_megert: review+
Target Milestone: 3.6 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
03.000.710_UnnecessaryMnemonic.gif
none
03.000.720_UnnecessaryMnemonic.gif
none
untitled.GIF
none
Proposed fix none

Description CDE Administration CLA 2010-05-18 11:20:53 EDT 
<response_by> martine marin at 2010.05.18.08.44.46 </response_by>
Hi,

All items under "Class" in API Compatibility DO NOT have mnemonic, only one string.
The mnemonic is duplicate and it is hard to have it unique. Please remove it.

File:
eclipse\plugins\org.eclipse.pde.api.tools.ui\org\eclipse\pde\api\tools\ui\internal\preferences\preferencemessages.properties

CLASS_CHANGED_NON_FINAL_TO_FINAL=The key&word 'final' has been added:

Same for Interface
INTERFACE_REMOVED_TYPE_MEMBER=A member type has been &removed:

Same for Enum
ENUM_REMOVED_FIELD=A fie&ld has been removed:

Same for Field
FIELD_REMOVED_TYPE_ARGUMENT=A type ar&gument has been removed:

Same for Method
METHOD_CHANGED_NON_FINAL_TO_FINAL=The &keyword 'final' has been added (type tagged '@noextend'):

Steps to reproduce:
Click Windows > Preferences
Click on Plugin Development
Click on API Errors /Warnings
Click on the API Compatibility tab
Expand Class
Expand Interface
Expand Enum
Expand Field
Expand Method

Thanks a lot in advance,

Martine

<response_by> rewagner at 2010.05.18.10.14.07 </response_by>
This article was reassigned from Category:''TVT/Testing,Inbox''.

<response_by> rewagner at 2010.05.18.10.16.25 </response_by>
I see this and it is being rerouted to the developers so they can remove it for future builds.

Thanks,
Ross

I have also included English screenshots of the pages to make it easier to fix the problem.
Comment 1 CDE Administration CLA 2010-05-18 11:21:01 EDT 
Created attachment 168948 [details]
03.000.710_UnnecessaryMnemonic.gif
Comment 2 CDE Administration CLA 2010-05-18 11:21:04 EDT 
Created attachment 168949 [details]
03.000.720_UnnecessaryMnemonic.gif
Comment 3 CDE Administration CLA 2010-05-18 11:21:06 EDT 
Created attachment 168950 [details]
untitled.GIF
Comment 4 CDE Administration CLA 2010-05-18 11:21:17 EDT 
<cde:tctdetail>
Testcase: 03.000.710  & 720 - BASE MANAGE CONFIG - PREFERENCES APIS ERRORS /WARNINGS - API COMPATIBILITY - CLASS & INTERFACE
Project: WSW36
Component: Xfer - Platform/UI
Priority: 2
Subject: FRA - Unnecessary mnemonic under Class in API Compatibility
Article ID: 288
Originator: mmarin@fr.ibm.com
</cde:tctdetail>
Comment 5 Olivier Thomann CLA 2010-05-18 14:15:45 EDT 
Created attachment 168991 [details]
Proposed fix
Comment 6 Olivier Thomann CLA 2010-05-18 14:16:07 EDT 
The same should apply to this option:
API_COMPONENT_REMOVED_REEXPORTED_TYPE=A re-exported type has been removed:
Comment 7 Olivier Thomann CLA 2010-05-18 14:16:38 EDT 
Michael, Darin, please review.
Comment 8 Michael Rennie CLA 2010-05-19 10:42:26 EDT 
patch looks good, although I thought having a mnemonic in each of the groups was intentional to match what JDT UI does on its Errors / Warnings page...
Comment 9 Olivier Thomann CLA 2010-05-19 10:56:54 EDT 
Released for 3.6RC2.
Comment 10 Darin Wright CLA 2010-05-21 10:55:57 EDT 
This fix is not in the build. Looks like "org.eclipse.pde.api.tools.ui" was never released to the build.
Comment 11 Darin Wright CLA 2010-05-21 10:56:50 EDT 
Targetting for RC3. Nothing critical - it can wait.
Comment 12 Dani Megert CLA 2010-05-22 03:42:56 EDT 
I give +1 for the bug since it was already made/targeted for RC2. Please note though, that according to the official endgame plan rules:
    May 24-27 - contributions to RC3
    Focus: Serious defects only; documentation.
this would be a -1:

Also note that in general we do give mnemonics to child items if they are important or often used. In this case however, it looks like PDE is not doing that and it was probably an oversight that some children have a mnemonic.
Comment 13 Olivier Thomann CLA 2010-05-25 12:56:13 EDT 
Tagged for next build.
Closing as FIXED.
Comment 14 Darin Wright CLA 2010-05-28 10:36:45 EDT 
Verified in I20100527-1700
Comment 15 CDE Administration CLA 2010-06-01 12:46:16 EDT 
<response_by> martine marin at 2010.06.01.11.34.59 </response_by>
I saw the changes in PII9A, should be implemented in Thursday's build when this package will be integrated.
Thanks,
Martine
Comment 16 CDE Administration CLA 2010-06-04 12:07:06 EDT 
<response_by> martine marin at 2010.06.04.11.02.14 </response_by>
Fixed thanks a lot,
Closing,
Martine