Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313340

Summary:	[EMF Compare] GenericMatchEngine is restricted to XMIResources
Product:	[Modeling] EMFCompare	Reporter:	Christian Schneider <christian.schneider>
Component:	Core	Assignee:	EMF Compare <emf.compare-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	blocker
Priority:	P3	CC:	laurent.goubet
Version:	1.1
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Christian Schneider

2010-05-18 08:52:37 EDT

Matching, diffing and merging is restricted to XMIResources by the following code in method doMatch in GenericMatchEngine.java:

if (!structuredOptions.isIgnoringXMIID())
    if (leftResource instanceof XMIResource && rightResource
            instanceof XMIResource) {
        checker.init(leftResource, rightResource);
}

This prohibits proper comparing of XtextResources, for example.

See also http://www.eclipse.org/forums/index.php?t=rview&goto=533818&th=168091

Comment 1 Cedric Brun

2010-05-18 08:58:09 EDT

That's kind of an overlook, I  fixed it and added unit tests for non XMI resources. The build is going on and should be available in the next hours.

Thanks for your feedback !

Comment 2 Laurent Goubet

2011-08-18 04:01:43 EDT

Closing this bug now.

Comment 3 Christian Schneider

2011-08-18 04:05:27 EDT

(In reply to comment #2)
> Closing this bug now.

It works for me :-)

Comment 4 Laurent Goubet

2011-08-18 04:23:38 EDT

(In reply to comment #3)
> (In reply to comment #2)
> > Closing this bug now.
> 
> It works for me :-)

Thanks for the feedback :). At least we are sure that it indeed fixed the issue for you :).

Comment 5 Christian Schneider

2011-08-18 04:35:50 EDT

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Closing this bug now.
> > 
> > It works for me :-)
> 
> Thanks for the feedback :). At least we are sure that it indeed fixed the issue
> for you :).

If you are curious about the result, have a look at
http://rtsys.informatik.uni-kiel.de/~chsch/videokitsaudio.mp4