Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313337

Summary:

Improper refactoring and highlight of occurrences of templates and queries

Product:

[Modeling] Acceleo

Reporter:

Stephane Begaudeau <stephane.begaudeau>

Component:

Core

Assignee:

Project Inbox <acceleo-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jonathan.musset, mariot.chauvin

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	none
Patch v2.0	mariot.chauvin: iplog+

Description Stephane Begaudeau

2010-05-18 08:48:27 EDT

Build Identifier: Build id: I20100429-1549

The highlight occurrences process and the refactoring process will consider as a match templates and queries with the same name even if they have different parameters.

Reproducible: Always

Steps to Reproduce:
If you have a module with two templates like :
[template public myTemplate(e : EClass)]
 hi
[/template]

[template public myTemplate(e : EOperation)]
 hello
[/template]

If you select one template, you will see both templates highlighted. If you refactor one template, both will be refactored.

Comment 1 Stephane Begaudeau

2010-05-18 08:50:10 EDT

Created attachment 168912 [details]
Patch

Improve the search of occurrences of an element, therefore it corrects both problems. Two templates/Queries are considered equals not only if they have the same name but also the same parameters.

Comment 2 Jonathan MUSSET

2010-05-19 10:41:51 EDT

Change IPlog flag.

Comment 3 Stephane Begaudeau

2010-05-20 07:16:42 EDT

Created attachment 169311 [details]
Patch v2.0

Improvement over the last patch. By correcting the problem, the last patch revealed a bug in the refactoring of templates and variables, it is now corrected.

Comment 4 Jonathan MUSSET

2010-05-20 10:11:39 EDT

Fixed for Acceleo 3.0 RC2