Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313325

Summary:

Browser: infinite refresh while browsing FacetSet

Product:

[Modeling] MoDisco

Reporter:

Nicolas Bros <nicolas.bros>

Component:

Infrastructure

Assignee:

Nicolas Bros <nicolas.bros>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

gdupe, hugo.bruneliere, modisco.web-inbox

Version:

0.8.0

Flags:

nicolas.bros: helios+
hugo.bruneliere: review+

Target Milestone:

0.8.0

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch	none

Description Nicolas Bros

2010-05-18 07:15:47 EDT

- "Navigate > Open EPackage"
- Choose the EPackage of a FacetSet (for example "http://www.eclipse.org/MoDisco/examples/java/javaTypesCustomizationFacet")
- Expand the FacetSet in the "Instances" panel

The browser refreshes continuously while the FacetSet is expanded in the Instances panel.

This is because FacetSetImpl#getFacets populates an EObjectEList, which triggers model modification notifications, which makes the browser refresh. And each time the browser refreshes, it calls this getFacets method, and so on...

Comment 1 Nicolas Bros

2010-05-18 08:16:36 EDT

Created attachment 168904 [details]
patch

Comment 2 Hugo Bruneliere

2010-05-18 08:21:25 EDT

Hi Nicolas,

You can go ahead with this patch.

Regards,

Hugo

Comment 3 Nicolas Bros

2010-09-27 08:37:07 EDT

I forgot to mark this old bug as fixed.

Comment 4 Hugo Bruneliere

2010-10-04 13:06:44 EDT

The patch has been successfully applied.