Bugzilla – Full Text Bug Listing
| Summary: | [implementation][preferences][spell checking] Move disabling of spelling for performance tests into tests itself | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> | ||||||
| Component: | Text | Assignee: | Deepak Azad <deepakazad> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | frederic_fusier | ||||||
| Version: | 3.3 | Flags: | daniel_megert:
review+
|
||||||
| Target Milestone: | 3.7 M3 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Dani Megert
Created attachment 180291 [details]
fix
The patch
- removes the spell check disabling code from AbstractDecoratedTextEditorPreferenceConstants
- disables spell checking for all tests in o.e.jdt.text.tests.performance package
Frederic, this change may affect some other performance tests numbers if they deal with text editors. - DisableAutoBuildTestSetup now has side-effects - If a single test is executed then spelling would still be enabled :-( ==> Why don't you simply add it in TextPerformanceTestCase.setUp/tearDown? AFAIK most if not all text performance test cases inherit from that class. Created attachment 180336 [details] fix (In reply to comment #3) > ==> Why don't you simply add it in TextPerformanceTestCase.setUp/tearDown? > AFAIK most if not all text performance test cases inherit from that class. I tried to enable/disable the spell check once per all tests, but as discussed I now add that to TextPerformanceTestCase.setUp/tearDown. Patch looks good with two minor changes that I made before committing to HEAD: - TextPerformanceTestCase2: moved super.tearDown() to the end - OpenPreferencePageTest added super calls to setUp() and tearDown() Filed bug 327459 to verify the next performance results. Verified in I20101025-1800. |