Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313200

Summary:	[launch] User could be prompted for a CDI debugger when using DSF-GDB or EDC
Product:	[Tools] CDT	Reporter:	Marc Khouzam <marc.khouzam>
Component:	cdt-debug	Assignee:	cdt-debug-inbox <cdt-debug-inbox>
Status:	NEW ---	QA Contact:	Jonah Graham <jonah>
Severity:	normal
Priority:	P3	CC:	cdtdoug, pawel.1.piech
Version:	7.0
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Marc Khouzam

2010-05-17 13:38:37 EDT

The method CApplicationLaunchShortcut#findLaunchConfiguration() assumes we are using the CDI debugger.  In doing that, it tries to select the debugger type to use, and may prompt the user if it cannot choose a single one.

Neither DSF-GDB nor EDC use those debugger types, and therefore, such a prompt would be quite confusing for the user.

I suggest we simply check which launch delegate will be used and if it is not the CDI one, ignore that piece of code.

I'll write a patch.

Comment 1 Doug Schaefer

2010-05-17 14:27:46 EDT

Why not just check which debugger is associated with the toolchain in the current build config and use that one instead of prompting. Oh, wait :P

Comment 2 Marc Khouzam

2010-05-17 15:36:07 EDT

(In reply to comment #1)
> Why not just check which debugger is associated with the toolchain in the
> current build config and use that one instead of prompting. Oh, wait :P

Is this guaranteed to work?  When I test, I never actually get the prompt because of this toolchain check.  But the code does prepare for the possibility that this check will not yield a debugger (or a single one).  That is the part that had me worried.

What do you think, do we need a check for DSF-GDB and EDC, or is the toolchain check enough?