Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313189

Summary: Available target runtimes list sometimes not filtered correctly
Product: [WebTools] WTP Common Tools Reporter: Konstantin Komissarchik <konstantin>
Component: Faceted Project FrameworkAssignee: Konstantin Komissarchik <konstantin>
Status: RESOLVED FIXED QA Contact: Konstantin Komissarchik <konstantin>
Severity: major    
Priority: P3 Flags: konstantin: pmc_approved? (david_williams)
konstantin: pmc_approved? (raghunathan.srinivasan)
konstantin: pmc_approved? (naci.dai)
deboer: pmc_approved+
konstantin: pmc_approved? (neil.hauge)
konstantin: pmc_approved? (kaloyan)
Version: 3.2   
Target Milestone: 3.2 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard: PMC_approved
Attachments:
Description Flags
Patch none

Description Konstantin Komissarchik CLA 2010-05-17 12:50:01 EDT
Scenario:

You have to runtimes R1 and R2. You also have two facets F1 and F2 that are specific to those runtimes.

1. Start with a web project targeting R1.
2. Go to project facets page. 
3. Switch to target runtimes tab.
4. Uncheck R1.
5. You should see F2 show up in the list of facets.
6. Check F2.
7. Runtime R1 should disappear from the list of runtimes on the right (as it does not support facet F2). Note that it does not disappear.
Comment 1 Konstantin Komissarchik CLA 2010-05-17 12:52:10 EDT
Created attachment 168763 [details]
Patch

Removes a chunk of problematic code that was used to be necessary, but is not relevant any more.
Comment 2 Konstantin Komissarchik CLA 2010-05-17 12:54:14 EDT
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This was seen in an adopter product when testing interaction of WebLogic and GlassFish runtimes and their corresponding facets.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No.

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Manual testing of the described scenario and framework unit tests.

    * Give a brief technical overview. Who has reviewed this fix? 

See Comment #1.

    * What is the risk associated with this fix? 

Low.
Comment 3 Konstantin Komissarchik CLA 2010-05-18 21:17:02 EDT
Patch released to 3.2 RC2 stream and fproj code line.