Bugzilla – Full Text Bug Listing
| Summary: | [Usability] Refactor CreateModelWizard | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Papyrus | Reporter: | Tatiana Fesenko <tatiana.fesenko> | ||||||||||||||
| Component: | Core | Assignee: | Tatiana Fesenko <tatiana.fesenko> | ||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||
| Severity: | enhancement | ||||||||||||||||
| Priority: | P3 | CC: | rschnekenburger, tatiana.fesenko | ||||||||||||||
| Version: | unspecified | Flags: | sebastien.gerard:
iplog-
|
||||||||||||||
| Target Milestone: | --- | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Windows XP | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Bug Depends on: | 276286 | ||||||||||||||||
| Bug Blocks: | 267010 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 168758 [details]
Initial patch
The way models are loaded/created is about to be changed (in less than 2 days). Please wait before applying the patch as the model loading changes will certainly impact the CreateModelWizard. > The way models are loaded/created is about to be changed (in less than 2
> days).
Cedric, could you provide me a number of this request. It will allow me to track status of the bug and better plan my own work. Thank you.
(In reply to comment #3) > > The way models are loaded/created is about to be changed (in less than 2 > > days). > Cedric, could you provide me a number of this request. It will allow me to > track status of the bug and better plan my own work. Thank you. Cedric, any update on this topic? It pauses my work with bug #267010 Depends on bug #276286 . What will change is the way to create models. (In reply to comment #5) > Depends on bug #276286 . > What will change is the way to create models. Cedrik, thank you for providing number of blocking request. It will help me to plan my own work. Created attachment 169501 [details]
Initial refactoring
(In reply to comment #7) > Created an attachment (id=169501) [details] > Initial refactoring Remi, could you commit the patch to SVN? Thank you! (In reply to comment #8) > (In reply to comment #7) > > Created an attachment (id=169501) [details] [details] > > Initial refactoring > > Remi, could you commit the patch to SVN? Thank you! commit in r1693 Thanks! Created attachment 169796 [details]
Javadoc added
(In reply to comment #10) > Created an attachment (id=169796) [details] > Javadoc added Committed in r1710. Thanks! Created attachment 169962 [details]
Refactoring - creation functionality was woved from the Wizard to the corresponding wizard pages
(In reply to comment #12) > Created an attachment (id=169962) [details] > Refactoring - creation functionality was woved from the Wizard to the > corresponding wizard pages Patch applied in r1718. Thanks ;) Created attachment 169963 [details]
Propoes Patch
(In reply to comment #14) > Created an attachment (id=169963) [details] > Propoes Patch Applied in r1720. Thanks! Created attachment 170771 [details]
Refactor SelectTemplateWizardPage
(In reply to comment #16) > Created an attachment (id=170771) [details] > Refactor SelectTemplateWizardPage Applied in r1775. Thanks ;-) Fixed |
Now CreateModelWizard class has checks like this almost in every method: if (templatePath != null) {...} else {...} It(and some other methods ) makes it very difficult to re-use (say, in bug #267010 ' [General] Project creation wizard creating a new project and a new Papyrus model at once') Refactor the code of CreateModelWizard for easier re-user