Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313175

Summary:

No problem generated when missing output.<lib> entry

Product:

[Eclipse Project] PDE

Reporter:

Darin Wright <darin.eclipse>

Component:

Assignee:

Ankur Sharma <ankur_sharma>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public

Version:

3.6

Flags:

ankur_sharma: review+
curtis.windatt.public: review+

Target Milestone:

3.6 RC2

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

309157, 313564

Bug Blocks:

Attachments:

Description	Flags
Patch	none
patch	none

Description Darin Wright

2010-05-17 11:49:58 EDT

Comment 1 Darin Wright

2010-05-17 11:52:09 EDT

3.6 RC1

* Check out "org.eclipse.debug.examples.core" from CVS
* open build.properties
* delete the "output.." entry

No problem is generated, but there should be a warning for the missing output entry.

Comment 2 Darin Wright

2010-05-17 11:53:38 EDT

When I try a similar thing with "org.eclipse.debug.core" and delete the output.core entry, I get a warning that there is no output for the "core" source folder.

Comment 3 Darin Wright

2010-05-17 11:54:11 EDT

Investigate for RC2.

Comment 4 Ankur Sharma

2010-05-18 05:40:25 EDT

I tried on N20100517-2000 and saw the marker getting generated after turning the preference on (to error or warning).

Source folder 'pdavm/src/, src_ant/' does not have the output folder in corresponding output entry 'output..'. 

However, it misses "src/". Investigating.

Comment 5 Ankur Sharma

2010-05-18 08:15:28 EDT

Created attachment 168903 [details]
Patch

Comment 6 Darin Wright

2010-05-18 10:00:33 EDT

With this patch, and the steps in comment#1, I still see no problem generated. The project uses default settings, which is a "warning" severity.

Comment 7 Darin Wright

2010-05-18 16:37:54 EDT

Created attachment 169015 [details]
patch

Here's an alternative patch. The fix was working - I was mislead by the fact there are two preferences that pertain to output.<entries>. Indeed, I had the severity level set to ignore.

This patch cleans up the the implementation of MissingOutputEntry a bit. It avoids the client from knowing about the internals, checking for contains, etc. If we going to use a local class for convenience/OO reasons, we might as well let the object do as much as it can internally.

Ankur, please review.

Comment 8 Ankur Sharma

2010-05-18 16:42:42 EDT

+1

Comment 9 Curtis Windatt

2010-05-19 12:11:28 EDT

+1 Fixed in HEAD.

Comment 10 Darin Wright

2010-05-21 11:46:59 EDT

Verified.