Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313148

Summary: [refactoring] Refactoring history doesn't seem to be formatting strings properly when removing an entry
Product: [Eclipse Project] JDT Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Deepak Azad <deepakazad>
Status: VERIFIED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: daniel_megert, raksha.vasisht
Version: 3.6Flags: daniel_megert: review+
raksha.vasisht: review+
Target Milestone: 3.6 RC2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
fix
daniel_megert: review+
fix daniel_megert: review+

Description Remy Suen CLA 2010-05-17 10:49:17 EDT
I20100513-1500

1. Create a Java project.
2. Make a class in the source folder.
3. Delete it.
4. Access the project's properties > Refactoring history
5. Keep expanding, you'll see a 'Delete element' entry, select it.
6. Click the 'Remove' button. You will get a message popup saying:

Are you sure you want to delete the refactoring from the refactoring history of project '{1}'?
Comment 1 Dani Megert CLA 2010-05-17 11:00:02 EDT
This is a regression.
Comment 2 Deepak Azad CLA 2010-05-17 12:54:32 EDT
Created attachment 168764 [details]
fix
Comment 3 Deepak Azad CLA 2010-05-18 01:51:26 EDT
Review needed for RC2.
Comment 4 Raksha Vasisht CLA 2010-05-18 02:48:43 EDT
(In reply to comment #3)
> Review needed for RC2.

+1 for RC2. You need to update the copyrights in 
RefactoringUIMessages.properties
Comment 5 Dani Megert CLA 2010-05-18 04:01:06 EDT
The patch looks good once the copyright is updated.

Did you check all our source projects for similar issues? I suggest you do a regex search using "=\D*\{1\}" and check all matches for potential issues.
Comment 6 Dani Megert CLA 2010-05-18 04:03:18 EDT
Please commit the fix to HEAD so that it will be included in I20100518-0800.
Comment 7 Deepak Azad CLA 2010-05-18 05:32:16 EDT
Created attachment 168881 [details]
fix

Fixed copyright. Fixed one more string with the same problem.

Patch released to HEAD.
Comment 8 Dani Megert CLA 2010-05-18 06:09:53 EDT
.
Comment 9 Dani Megert CLA 2010-05-19 03:59:56 EDT
Verified both strings in N20100518-2000.