| Summary: | [refactoring] Refactoring history doesn't seem to be formatting strings properly when removing an entry | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Remy Suen <remy.suen> | ||||||
| Component: | UI | Assignee: | Deepak Azad <deepakazad> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | minor | ||||||||
| Priority: | P3 | CC: | daniel_megert, raksha.vasisht | ||||||
| Version: | 3.6 | Flags: | daniel_megert:
review+
raksha.vasisht: review+ |
||||||
| Target Milestone: | 3.6 RC2 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
This is a regression. Created attachment 168764 [details]
fix
Review needed for RC2. (In reply to comment #3) > Review needed for RC2. +1 for RC2. You need to update the copyrights in RefactoringUIMessages.properties The patch looks good once the copyright is updated.
Did you check all our source projects for similar issues? I suggest you do a regex search using "=\D*\{1\}" and check all matches for potential issues.
Please commit the fix to HEAD so that it will be included in I20100518-0800. Created attachment 168881 [details]
fix
Fixed copyright. Fixed one more string with the same problem.
Patch released to HEAD.
. Verified both strings in N20100518-2000. |
I20100513-1500 1. Create a Java project. 2. Make a class in the source folder. 3. Delete it. 4. Access the project's properties > Refactoring history 5. Keep expanding, you'll see a 'Delete element' entry, select it. 6. Click the 'Remove' button. You will get a message popup saying: Are you sure you want to delete the refactoring from the refactoring history of project '{1}'?