Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313147

Summary: Change examples from old-style plugins to real OSGi bundles in 3.7
Product: [Eclipse Project] Platform Reporter: Darin Wright <darin.eclipse>
Component: RelengAssignee: Platform-Releng-Inbox <platform-releng-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, kim.moir
Version: 3.6   
Target Milestone: 3.7 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 316050, 316052    
Bug Blocks:    
Attachments:
Description Flags
patch for org.eclipse.sdk.examples
none
patch for org.eclipse.sdk.examples none

Description Darin Wright CLA 2010-05-17 10:48:06 EDT
Some example bundles should be re-versioned to get source reference headers generated. In 3.6 RC1, I see the following bundles without headers:

org.eclipse.compare.examples.xml
org.eclipse.compare.examples
org.eclipse.sdk.examples
org.eclipse.team.examples.filesystem
org.eclipse.ui.examples.fieldassist
org.eclipse.ui.examples.javaeditor
org.eclipse.ui.examples.views.properties.tabbed.article
Comment 1 Kim Moir CLA 2010-05-17 11:22:55 EDT
These bundles don't have manifests, this is why it's missing the source references

org.eclipse.sdk.examples
org.eclipse.compare.examples.xml
org.eclipse.compare.examples
org.eclipse.sdk.examples
org.eclipse.team.examples.filesystem
org.eclipse.ui.examples.javaeditor

Not sure if we want to convert these bundles at this point in the release, Darin, what are your thoughts?

The tagging of 
org.eclipse.ui.examples.views.properties.tabbed.article
is covered in bug 311438
Comment 2 Darin Wright CLA 2010-05-17 12:11:08 EDT
(In reply to comment #1)
> Not sure if we want to convert these bundles at this point in the release,
> Darin, what are your thoughts?

I guess these are old-style plug-ins. Seems too late in the release to convert these. I would suggest to update the examples in 3.7 to be real OGSi bundles.
Comment 3 Kim Moir CLA 2010-06-28 09:31:21 EDT
Created attachment 172903 [details]
patch for org.eclipse.sdk.examples
Comment 4 Kim Moir CLA 2010-06-28 09:33:24 EDT
Created attachment 172904 [details]
patch for org.eclipse.sdk.examples
Comment 5 Kim Moir CLA 2010-06-29 10:10:42 EDT
Verified that sdk.examples bundle in N20100628-2000 build has the correct format and that the source references are properly reflected in the manifest.
Comment 6 Kim Moir CLA 2010-10-14 10:42:53 EDT
Closing.