Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313089

Summary: [Linker] Linker gets confused with actions
Product: [Modeling] TMF Reporter: Jan Koehnlein <jan>
Component: XtextAssignee: Jan Koehnlein <jan>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tmf.xtext-inbox
Version: 1.0.0Flags: jan: helios+
Target Milestone: RC1   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Patch for the Linker jan: review+

Description Jan Koehnlein CLA 2010-05-17 05:25:07 EDT 
When using the plain Linker, I get linking exceptions

Cannot find reference org.eclipse.xtext.impl.CrossReferenceImpl@7f867f7f
   (cardinality: null)

when actions are involved. Seems like the linker is trying to resolve a cross reference in the wrong context.
Comment 1 Jan Koehnlein CLA 2010-05-17 07:45:55 EDT 
Created attachment 168714 [details]
Patch for the Linker

Added a patch: 

org.eclipse.xtext.linking.impl.Linker.ensureLinked(EObject, IDiagnosticProducer, CompositeNode, Set<EReference>) did not stop ascending in the node model when the parent had another semantic model set. 

As the same condition was correct in the sibling class LazyLinker, I extracted the condition into a method of the superclass.

Test included.
Comment 2 Jan Koehnlein CLA 2010-05-17 07:54:16 EDT 
Renamed the method to shouldCheckParentNode, added JavaDocs and committed.
Comment 3 Karsten Thoms CLA 2017-09-19 16:27:46 EDT 
Closing bug which were set to RESOLVED before Eclipse Neon.0.