Bugzilla – Full Text Bug Listing
| Summary: | Variables should be sorted by name | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] JSDT | Reporter: | Michael Schneider <michschn> | ||||||||||
| Component: | Debug | Assignee: | Simon Kaegi <simon_kaegi> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | Simon Kaegi <simon_kaegi> | ||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | Michael_Rennie, potionsmasterz, thatnitind | ||||||||||
| Version: | 3.2 | Flags: | deboer:
pmc_approved+
thatnitind: review+ Michael_Rennie: review+ |
||||||||||
| Target Milestone: | 3.2 RC2 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Whiteboard: | PMC_approved | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 168729 [details]
proposed patch
This is something we want fixed for RC2. Indeed there is no sortinging and the variable order is from a hashmap. This is particularly bad for arrays and needs to be fixed.
This patch uses 1.5 code in a 1.4 bundle -1 from me. Reported error: "The method valueOf(String) in the type Integer is not applicable for the arguments (int)" ArrayReferenceImpl.java line 86 That aside the sorting does make it somewhat less painful to find a variable. Fixing bug 312287 would greatly help the variable confusion as well. Created attachment 168789 [details]
updated patch
Updating patch to use 1.4 method. Thanks Michael. Good catch.
Created attachment 168812 [details]
updated patch v2
Added "advanced" name1 matching to correct a typo (thanks Michael) as well as making variable name matching case insensitive and added [proto] as the first variable on Objects to be consistent with JDT Debug L&F.
looks good now. Fixed in HEAD |
Created attachment 168630 [details] Screenshot of the issue When using the variable view, the variables seems to be "hash-map" sorted. This makes it hard to spy a variable, especially because all scopes are shown in one list. In my scenario, where I basically start up a browser environment with Dojo, there are always lots of variables around. See attached screenshot