Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312977

Summary:

[ValueConverters] EFactory-based converters are only registerd for data-type rules

Product:

[Modeling] TMF

Reporter:

Sebastian Zarnekow <sebastian.zarnekow>

Component:

Xtext

Assignee:

Jan Koehnlein <jan>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jan, tmf.xtext-inbox

Version:

1.0.0

Flags:

sebastian.zarnekow: helios+

Target Milestone:

RC2

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
DefaultTerminalConverter + Test	jan: review+

Description Sebastian Zarnekow

2010-05-14 16:10:03 EDT

We should register them for terminal rules, too.

Comment 1 Sebastian Zarnekow

2010-05-14 16:11:30 EDT

Terminal-rule based EFactory converters should inherit from AbstractLexerBasedConverter.

Comment 2 Jan Koehnlein

2010-05-25 07:43:27 EDT

Created attachment 169811 [details]
DefaultTerminalConverter + Test

Use default value converters for terminal rules, delegating to the EFactory of the return type. 

All tests are green. I am committing this change, so we can roll it back using this patch if it fails in an unpredictable way.

Comment 3 Jan Koehnlein

2010-05-25 07:47:17 EDT

Patch applied.

Comment 4 Karsten Thoms

2017-09-19 16:28:51 EDT

Closing bug which were set to RESOLVED before Eclipse Neon.0.