Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312949

Summary:

switching between configs & typing in name field of LCD is slow

Product:

[Eclipse Project] Platform

Reporter:

Darin Wright <darin.eclipse>

Component:

Debug

Assignee:

Darin Wright <darin.eclipse>

Status:

VERIFIED FIXED

QA Contact:

Severity:

major

Priority:

CC:

curtis.windatt.public, Michael_Rennie

Version:

3.6

Keywords:

performance

Target Milestone:

3.6 RC2

Flags:

Michael_Rennie: review+
curtis.windatt.public: review+

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none
updated patch	none

Description Darin Wright

2010-05-14 13:34:17 EDT

The launch dialog refreshes after each key stroke in the name field. During 3.6 we added support for tabs to schedule a refresh job after a 200ms delay (org.eclipse.debug.ui.AbstractLaunchConfigurationTab.scheduleUpdateJob()), however, this was not done for the "Name:" field.

Comment 1 Darin Wright

2010-05-14 13:44:10 EDT

Created attachment 168571 [details]
patch

Uses the same logic as tabs to delay/update the LCD.

Comment 2 Darin Wright

2010-05-14 14:43:19 EDT

Even worse... the tabs are being disposed/recreated when switching between configs of the same type.

Comment 3 Darin Wright

2010-05-14 14:44:51 EDT

Created attachment 168580 [details]
updated patch

The code checking if launch delegates are equal for 2 configs did not consider if both "preferred" delegates were null or if the config types were equal. There would also have been a problem if 2 config types shared the same delegate (would be rare, but tabs would not have been re-drawn).

Comment 4 Michael Rennie

2010-05-17 12:59:20 EDT

looks ok

Comment 5 Curtis Windatt

2010-05-18 14:34:26 EDT

+1 Fixed in HEAD.

Comment 6 Curtis Windatt

2010-05-18 14:37:53 EDT

Verified by two committers.