Bug 312923

Comment 1 CDE Administration 2010-05-14 11:05:47 EDT

Created attachment 168546 [details]
02.000.110.gif

Comment 2 CDE Administration 2010-05-14 11:05:51 EDT

<cde:tctdetail>
Testcase: 02.000.110 - BASE FILE MENU - TVT PROJECT - SEARCH
Project: WSW36
Component: Xfer - Platform/Search
Priority: 3
Subject: JPN: Extra spaces in front of the second Regular expression checkbox
Article ID: 252
Originator: terak@jp.ibm.com
</cde:tctdetail>

Comment 3 Markus Keller 2010-05-14 11:31:26 EDT

That's not a search page from the SDK. Could you please give us the English name of the tab, so that we can move the bug to the right component? Or even better: Press Alt+Shift+F1 to see the contributing class/plug-in of the page.



(In reply to comment #0)
> ----------------
> Procedure
> 
> Start Eclipse
> In Workspace Launcher panel, you should accept the default and click the
> checkbox so you won't be prompted every time you start Eclipse
> Click OK
> Double click on Welcome
> On the menu bar from the main Workbench panel, click File --> New -> Project ->
> Java Project
> Double click on Java Project
> Next to Project name type TVT
> Click on the Next button
> Click on the Libraries tab
> Upon validating the panel click on the Finish button

I don't understand what these steps should have to do with the reported bug.

Comment 4 Dani Megert 2010-05-16 11:13:25 EDT

AFAIK the translations are provided by IBM and hence the bug is not with Eclipse.

Comment 5 CDE Administration 2010-05-16 21:31:36 EDT

<response_by> Keiko Terada at 2010.05.16.20.06.44 </response_by>
The Search dialog is opened in Remote system explorer perspective.
Please see the screenshot taken on 20100516-0300.

Comment 6 CDE Administration 2010-05-16 21:31:41 EDT

Created attachment 168659 [details]
252_02.000.110_20100516-0300.gif

Comment 7 Kit Lo 2010-05-16 21:44:50 EDT

Can the RSE team take a look at this to see if there is a layout problem near the checkbox?

Comment 8 CDE Administration 2010-05-18 10:36:14 EDT

<response_by> Manuel Ferro at 2010.05.18.09.33.11 </response_by>
Same problem for PTG and we, testers and translator, don't have the capability to align that text.

Regards,
Ricardo

Comment 9 Xuan Chen 2010-05-18 16:19:58 EDT

I took a look at the code, it seems this problem is related to the fix for bug 279307.

For the regular expression button for file name, it was changed from GridData.HORIZONTAL_ALIGN_BEGINNING to GridData.HORIZONTAL_ALIGN_END.  Is it intentional?

This is the source code fragment for SystemSearchPage#createFileNameControl()

                //gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING);
		
		gd = new GridData(GridData.HORIZONTAL_ALIGN_END);
		gd.horizontalSpan = 3;
		
		fileNameRegexButton.setLayoutData(gd);
		fileNameRegexButton.setSelection(initialFileNameRegex);
		fileNameHintLabel.setVisible(!fileNameRegexButton.getSelection());

Comment 10 Xuan Chen 2010-05-19 11:25:20 EDT

There was a reason for changing HORIZONTAL_ALIGN_BEGINNING to HORIZONTAL_ALIGN_END.  If I tried it using HORIZONTAL_ALIGN_BEGINNING, the 
"Regular Expression" checkbox will be added to the next line.

It is a minor issue, we will look into how to fix it properly later.

Comment 11 Xuan Chen 2010-05-19 11:27:15 EDT

Created attachment 169139 [details]
screen capture for change to HORIZONTAL_ALIGN_BEGINNING

Comment 12 Kit Lo 2010-05-20 00:54:23 EDT

Created attachment 169264 [details]
fix

Xuan, the regex checkbox for search string lined up properly because there is a label in the first column. I created a dummy label before the regex checkbox for file name, then the regex checkbox is lined up properly.

Since I don't have access to the RSE CVS repository, I cannot create a patch. Please review this fix. Hope that helps!

Comment 13 Kit Lo 2010-05-20 00:55:46 EDT

Created attachment 169265 [details]
Layout in Japanese after fix

Comment 14 Xuan Chen 2010-05-20 13:54:26 EDT

I made the code change according to Kit's suggestion, and it worked.

Please see the attachment for the patch (with comparison info).

I will commit the patch into CVS.  

Kit, could you please add the legal statement to the comment of this bug?  Thanks.

Comment 15 Xuan Chen 2010-05-20 13:55:33 EDT

Created attachment 169390 [details]
patch for the fix

Comment 16 Xuan Chen 2010-05-20 13:57:05 EDT

Kevin, could you please review this fix?  Thanks.

Comment 17 Kevin Doyle 2010-05-20 14:14:17 EDT

Review +.

Comment 18 Kit Lo 2010-05-20 14:36:02 EDT

I, Kit Lo, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer, IBM Corporation, to make this contribution under the EPL.

Comment 19 Xuan Chen 2010-05-20 14:43:08 EDT

I committed the fix.

Comment 20 Martin Oberhuber 2010-05-21 07:02:38 EDT

Thanks for the fix! I released it for I20100521-0702.

We need to add an iplog+ on the contribution, to add it to our IP Log. Kit - in order to do this properly, could you please attach the fix as a patch? I assume you could just download and re-attach what Xuan attached yesterday.

Sorry for this extra effort, but it's the only way I see the IP Log tooling work properly for this.

Thanks!

Comment 21 Kit Lo 2010-05-21 07:09:32 EDT

Created attachment 169488 [details]
patch

Here is my patch.

Comment 22 Martin Oberhuber 2010-05-21 07:11:56 EDT

Comment on attachment 169488 [details]
patch

Thanks!

Comment 23 CDE Administration 2010-05-21 12:06:53 EDT

<response_by> Manuel Ferro at 2010.05.21.10.58.06 </response_by>
It's fine, for portuguese, in build 20100520-0200

Regards,
Ricardo

Comment 24 CDE Administration 2010-05-24 02:01:21 EDT

<response_by> Keiko Terada at 2010.05.24.00.39.32 </response_by>
Verified fix for JA in 20100522-1600, thanks.