Bugzilla – Full Text Bug Listing
| Summary: | New ClippingStrategy causes Exception if connection remains after deleting Figure | ||
|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | <h1055071> |
| Component: | GEF-Legacy GEF (MVC) | Assignee: | Alexander Nyßen <nyssen> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | nyssen, yann.tanguy |
| Version: | unspecified | ||
| Target Milestone: | 3.6.2 (Helios SR2) | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
It happens as a side-effect of not removing the connections from the deleted object. In 3.5.2 the orphaned connection(s) would remain on the diagram, but in 3.6 there is this exception. You could argue that you when you run a Delete command you should also remove any connections from the model. This is true, but at least in 3.5.2 it acted gracefully. To reproduce in Logic example: 1. In DeleteCommand.java comment out the code in methods deleteConnections(LogicSubpart part). 2. Create a new Logic diagram and add a FullAdder and a Circuit. 3. Make a connection from an inner figure in the FullAdder to a point on the Circuit. 4. Delete the inner figure's parent. The cause for this actually is that FigureUtilities#findCommonAncestor is not robust against calls with an orphaned figure. The following test case may be used to reproduce the issue:
public void test_findCommonAncestor_bugzilla312886() {
IFigure orphanFigure = new Figure();
IFigure figureParent = new Figure();
IFigure figureChild = new Figure();
figureParent.add(figureChild);
assertNull(FigureUtilities
.findCommonAncestor(figureChild, orphanFigure));
}
It will deliver the following result: IndexOutOfBoundsException: Index : 2, Size:2
- Fixed javadoc of FigureUtilities#findCommonAncestor() stated that the method would return null in case one figure is the ancestor of the other (the changes made as part of bug#130042 and the test case belonging to this demonstrated that other behavior was expected). - Reimplemented FigureUtilities#findCommonAncestor() to correctly handle orphaned children, which was broken. - Made ViewportUtilities#findNearestViewport() and ViewportUtilities#findNearestEnclosingViewport() robust against null arguments. - Added additional test cases to FigureUtilitiesTest. Committed changes to 3.6 maintenance branch and cvs HEAD (3.7). Marking as resolved in 3.6.2. |