Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312872

Summary: NPE having enabled Error on "Missing project specific Java compiler settings"
Product: [Eclipse Project] PDE Reporter: James Blackburn <jamesblackburn+eclipse>
Component: UIAssignee: Ankur Sharma <ankur_sharma>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, darin.eclipse
Version: 3.6Flags: darin.eclipse: review+
curtis.windatt.public: review+
Target Milestone: 3.6 RC2   
Hardware: PC   
OS: Linux-GTK   
Whiteboard:
Attachments:
Description Flags
Patch none

Description James Blackburn CLA 2010-05-14 04:34:40 EDT 
3.6.0M7
Having tweaked this Workspace setting (discovered from the M7 N&N):
http://download.eclipse.org/eclipse/downloads/drops/S-3.6M7-201004291549/eclipse-news-M7.html

I ended up with a bunch of NPEs in the Error Log.

java.lang.NullPointerException
at org.eclipse.pde.internal.core.builders.SourceEntryErrorReporter$Visitor.visit(SourceEntryErrorReporter.java:242)
at org.eclipse.core.internal.resources.Resource$2.visit(Resource.java:112)
at org.eclipse.core.internal.resources.Resource$1.visitElement(Resource.java:64)
at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:82)
at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:86)
at org.eclipse.core.internal.watson.ElementTreeIterator.iterate(ElementTreeIterator.java:127)
at org.eclipse.core.internal.resources.Resource.accept(Resource.java:74)
at org.eclipse.core.internal.resources.Resource.accept(Resource.java:110)
at org.eclipse.core.internal.resources.Resource.accept(Resource.java:94)
at org.eclipse.pde.internal.core.builders.SourceEntryErrorReporter.validate(SourceEntryErrorReporter.java:518)
at org.eclipse.pde.internal.core.builders.BuildErrorReporter.validateBuild(BuildErrorReporter.java:233)
at org.eclipse.pde.internal.core.builders.BuildErrorReporter.validate(BuildErrorReporter.java:139)
at org.eclipse.pde.internal.core.builders.ErrorReporter.validateContent(ErrorReporter.java:127)
at org.eclipse.pde.internal.core.builders.ManifestConsistencyChecker.validateBuildProperties(ManifestConsistencyChecker.java:316)
at org.eclipse.pde.internal.core.builders.ManifestConsistencyChecker.validateProject(ManifestConsistencyChecker.java:231)
at org.eclipse.pde.internal.core.builders.ManifestConsistencyChecker.build(ManifestConsistencyChecker.java:157)
at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:629)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:172)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:282)
at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:363)
at org.eclipse.core.internal.resources.Project$1.run(Project.java:545)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1975)
at org.eclipse.core.internal.resources.Project.internalBuild(Project.java:524)
at org.eclipse.core.internal.resources.Project.build(Project.java:123)
at org.eclipse.pde.internal.ui.preferences.PDECompilersConfigurationBlock$5.run(PDECompilersConfigurationBlock.java:915)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 1 Darin Wright CLA 2010-05-14 09:27:28 EDT 
Investigate for RC2.
Comment 2 Ankur Sharma CLA 2010-05-17 03:56:18 EDT 
Can you please confirm that there is a file without any extension in one of the source folders of the plug-in that threw this NPE.
Comment 3 Ankur Sharma CLA 2010-05-17 03:57:40 EDT 
Created attachment 168690 [details]
Patch

Fixed the NPE by checking the file extension for being null
Comment 4 James Blackburn CLA 2010-05-17 04:09:57 EDT 
Yes, there seem to be.

BTW a neater fix might be:
"java".equals(file.getFileExtension())
Comment 5 Ankur Sharma CLA 2010-05-17 10:54:33 EDT 
I agree.
Thanks for catching that.
Comment 6 Curtis Windatt CLA 2010-05-18 10:37:23 EDT 
+1 Fixed in HEAD.
Comment 7 Curtis Windatt CLA 2010-05-21 11:40:34 EDT 
Verified.