Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312848

Summary: Remove CDI-GDB pref to enable distinct code and data spaces
Product: [Tools] CDT Reporter: John Cortell <john.cortell>
Component: cdt-debug-cdi-gdbAssignee: John Cortell <john.cortell>
Status: RESOLVED FIXED QA Contact: Elena Laskavaia <elaskavaia.cdt>
Severity: normal    
Priority: P3 CC: marc.khouzam, pawel.1.piech
Version: 7.0   
Target Milestone: 8.0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fix john.cortell: iplog-

Description John Cortell CLA 2010-05-13 19:15:34 EDT 
I added the pref years ago as a quick solution to the unexpected appearance of memory space options in the Add Memory Monitor dialog. On revisiting this, I've determined there is no need for the checkbox, as CDI-GDB doesn't support memory spaces at all. Any other CDI client that does support memory spaces will automatically get the memory space options in the dialog. In addition to removing the checkbox, I'm making the GDB ICDITarget no longer implement ICDIMemorySpaceManagement as there's no point to it doing so.
Comment 1 John Cortell CLA 2010-05-13 19:16:19 EDT 
Created attachment 168490 [details]
Fix
Comment 2 John Cortell CLA 2010-05-13 19:16:56 EDT 
Committed to HEAD
Comment 4 CDT Genie CLA 2010-07-28 15:27:39 EDT 
*** cdt cvs genie on behalf of jcortell ***
Bug 312848: Remove CDI-GDB pref to enable distinct code and data spaces. Also fixed warnings

[*] Target.java 1.64 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/model/Target.java?root=Tools_Project&r1=1.63&r2=1.64