Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312830

Summary: [Mozilla] XPCOM error when removing DOM listeners should not crash
Product: [Eclipse Project] Platform Reporter: Grant Gayed <grant_gayed>
Component: SWTAssignee: Grant Gayed <grant_gayed>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.6   
Target Milestone: 3.7 M1   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch none

Description Grant Gayed CLA 2010-05-13 14:45:08 EDT 
When showing the Welcome page at startup, if a Mozilla-based Browser is successfully created but then fails on the subsequent setText() call the workbench is immediately brought down.  This disposes the Browser, which unhooks its DOM listeners.  However the setText() failure can leave the underlying browser in an inconsistent state, which causes the listener unhooking to fail also.

Currently when this happens an error is thrown for the listener unhooking failure, which covers up the original error.  This failure should not cause a crash, firstly because the original error should not be covered up (it's the one that matters), and secondly because failure to remove DOM listeners does not really matter (the Browser's future function should not be affected).
Comment 1 Grant Gayed CLA 2010-05-13 14:57:09 EDT 
Created attachment 168440 [details]
patch

It's the first call in unhookDOMListeners() that can fail in this scenario, so this is the only place that the patch changes.
Comment 2 Grant Gayed CLA 2010-06-25 16:06:36 EDT 
fixed > 20100625