Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312768

Summary:	IEGitOperation need to spec whether 'null' is allowed for execute(IProgressMonitor)
Product:	[Technology] EGit	Reporter:	Remy Suen <remy.suen>
Component:	Core	Assignee:	Jens Baumgart <jens.baumgart>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	caniszczyk, jens.baumgart, matthias.sohn
Version:	unspecified
Target Milestone:	0.8.0
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2010-05-13 06:06:50 EDT

This needs to be clearly stated in the javadocs.

I also suggest everyone read SubMonitor's javadoc.

Comment 1 Jens Baumgart

2010-05-25 11:49:33 EDT

Fix proposed: http://egit.eclipse.org/r/747

Comment 2 Chris Aniszczyk

2010-05-25 12:49:20 EDT

Merged.

Comment 3 Remy Suen

2010-05-25 12:53:02 EDT

Change 747 does not actually address the problem in question, that being the execute(IProgressMonitor) method outlined in this bug's summary.
http://egit.eclipse.org/r/#patch,sidebyside,747,1,org.eclipse.egit.core/src/org/eclipse/egit/core/op/IEGitOperation.java

All I see are changes for the getSchedulingRule() method.

Comment 4 Jens Baumgart

2010-05-26 04:35:12 EDT

Fix proposed: http://egit.eclipse.org/r/750

Comment 5 Matthias Sohn

2010-05-26 09:39:35 EDT

merged as 8ed98b6d0cd30d8e7b135ddc92650150b446c6d5