Bugzilla – Full Text Bug Listing
| Summary: | Build Improvements | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Sean Lamers <slamers> | ||||||||||
| Component: | TPTP | Assignee: | Sean Lamers <slamers> | ||||||||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P2 | CC: | ernest, jcayne | ||||||||||
| Version: | unspecified | Flags: | kathy:
pmc_approved?
(oec) ernest: pmc_approved+ kathy: pmc_approved+ kathy: pmc_approved? (paulslau) kathy: pmc_approved? (jgwest) jcayne: review+ |
||||||||||
| Target Milestone: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Sean Lamers
Created attachment 168299 [details]
Patch A - run multiple functions and tools in parallel
This patch includes changes to run multiple functions and tools in parallel during the build (in order to decrease the total build time). The following tools are modified to be non-blocking (via the Linux screen command):
- version check
- copyright check
- bug list and change log generation
- internal package use check
- chkpii
- javadoc
In addition, the patch modifies the calls for fetching build dependencies. Dependencies are downloaded in parallel but unzipped sequentially (I ran into build errors when they were unzipped in parallel - this should be investigated at a later date). Note that changes were also made to account for the fact that the equinox package is now in the form of a p2 repository.
The patch also adds checks for native build failures and moves the verify-plugins.sh call to occur earlier in the build; this will allow the build to fail earlier in the event of a compilation error.
Zip calls are also made quiet (in order to remove log clutter) in addition to other minor changes.
Joel, please review. Created attachment 168306 [details]
Patch A - run multiple functions and tools in parallel
Patch looks good.
Updated with some spacing changes and a modification to the mkdir -p for javadoc/jdiff.
Patch checked into HEAD. Thanks Joel! Can this be resolved now for TPTP 4.7? Created attachment 170528 [details]
Patch for publishing
Created attachment 170530 [details] Patch to remove babel map file Babel translation has been updated to point to hyades.map file as outlined in http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg03954.html so the babel.map file is no longer needed. It can be removed to save the extra tagging update step in the build. Patches look good. I would like to request for PMC approval to include the two attached fixes in TPTP v4.7.0. 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? The publishing patch will reduce the checkout of unnecessary files during the build. The babel map is no longer required as the build map (hyades.map) will be used by the babel project. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. No. 4. Does this require new API? No. 5. Who performed the code review? Sean 6. Is there a test case attached to the bugzilla record? n/a 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Low. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? n/a Requesting PMC approval for this build improvement for TPTP 4.7. Resolving. Verified on TPTP-4.7.0-201006081927. |