Bugzilla – Full Text Bug Listing
| Summary: | [breakpoints][tracepoints] The buttons to edit, delete and attach Bp and Tp actions are enabled when created | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Marc Khouzam <marc.khouzam> | ||||||
| Component: | cdt-debug | Assignee: | Marc Khouzam <marc.khouzam> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Ken Ryall <ken.ryall> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | pawel.1.piech | ||||||
| Version: | 7.0 | Flags: | marc.khouzam:
review?
(ken.ryall) |
||||||
| Target Milestone: | 7.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 168250 [details]
Fix
The fix is pretty simple.
Committed to HEAD.
Ken, can you review? *** cdt cvs genie on behalf of mkhouzam *** Bug 312706: Update the enablement of the buttons after they are created. [*] GlobalActionsList.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/breakpointactions/GlobalActionsList.java?root=Tools_Project&r1=1.2&r2=1.3 [*] TracepointGlobalActionsList.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/tracepointactions/TracepointGlobalActionsList.java?root=Tools_Project&r1=1.1&r2=1.2 |
Created attachment 168249 [details] Screenshot of problem Looking at the snapshot we can see that the Attach, Edit and Delete buttons are enabled even though nothing is selected. This is not nice and can lead to java.lang.ArrayIndexOutOfBoundsException: 0 at org.eclipse.cdt.debug.ui.breakpointactions.GlobalActionsList.HandleEditButton(GlobalActionsList.java:163) at org.eclipse.cdt.debug.ui.breakpointactions.GlobalActionsList$3.widgetSelected(GlobalActionsList.java:112) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1234)