Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312684

Summary: Image leak on the library provider install panel
Product: [WebTools] WTP Common Tools Reporter: Karen Butzke <karenfbutzke>
Component: Faceted Project FrameworkAssignee: Konstantin Komissarchik <konstantin>
Status: RESOLVED FIXED QA Contact: Konstantin Komissarchik <konstantin>
Severity: major    
Priority: P3 CC: raghunathan.srinivasan
Version: 3.2Flags: konstantin: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
konstantin: pmc_approved? (naci.dai)
konstantin: pmc_approved? (deboer)
konstantin: pmc_approved? (neil.hauge)
konstantin: pmc_approved? (kaloyan)
Target Milestone: 3.2 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
proposed patch - disposes image none

Description Karen Butzke CLA 2010-05-12 14:30:12 EDT 
There is an image leak on the osgi library provider install panel.  I found this because I got an SWT no more handles exception and eclipse crashed.  Wasn't necessarily fully caused by this leak, but helped to contribute to it.  I was creating JPA projects and modifying their properties, both of which use the library provider install panel. I will attach a patch that disposes of the image.
Comment 1 Karen Butzke CLA 2010-05-12 14:31:34 EDT 
Created attachment 168222 [details]
proposed patch - disposes image
Comment 2 Konstantin Komissarchik CLA 2010-05-12 20:56:03 EDT 
Thanks for the patch. Looks correct. Raising for PMC approval.

    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

Resource leak that can lead crash of Eclipse process.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No workaround.

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Manual testing.

    * Give a brief technical overview. Who has reviewed this fix? 

One of the allocated images was not disposed.

    * What is the risk associated with this fix? 

No risk.
Comment 3 Konstantin Komissarchik CLA 2010-05-17 12:06:04 EDT 
Released patch to 3.2 RC2 stream and fproj codeline. Thanks!