Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312677

Summary: Host OSGi console should have close action
Product: [Eclipse Project] PDE Reporter: Darin Wright <darin.eclipse>
Component: UIAssignee: PDE-UI-Inbox <pde-ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, tjwatson
Version: 3.6Keywords: polish
Target Milestone: 3.6 RC1Flags: curtis.windatt.public: review+
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
udpated patch
none
updated patch none

Description Darin Wright CLA 2010-05-12 14:02:45 EDT 
The Host OSGi console should have a close action/toolbar item similar to the Java stack trace console. The action should invoke the "disconnect" command.
Comment 1 Darin Wright CLA 2010-05-12 14:32:22 EDT 
Created attachment 168223 [details]
patch

Adds close button in the toolbar.
Comment 2 Darin Wright CLA 2010-05-12 14:32:53 EDT 
Please review, Curtis.
Comment 3 Thomas Watson CLA 2010-05-12 15:27:03 EDT 
Patch works for me.  Although I did find (and fix) a bug in the framework when testing this patch.  bug312691.
Comment 4 Darin Wright CLA 2010-05-12 15:59:20 EDT 
Created attachment 168245 [details]
udpated patch

This patch incorporates a fix to bug 312697. Since the two patches will collide, I have combined them.
Comment 5 Darin Wright CLA 2010-05-12 15:59:44 EDT 
*** Bug 312697 has been marked as a duplicate of this bug. ***
Comment 6 Thomas Watson CLA 2010-05-12 16:17:12 EDT 
Created attachment 168248 [details]
updated patch

in init() you should write the message before registering the console session to ensure the message is printed before the osgi> prompt.
Comment 7 Darin Wright CLA 2010-05-12 16:20:02 EDT 
(In reply to comment #6)
> Created an attachment (id=168248) [details]
> updated patch
> in init() you should write the message before registering the console session
> to ensure the message is printed before the osgi> prompt.

Makes sense. I never saw it happen, but wondered...
Comment 8 Curtis Windatt CLA 2010-05-12 17:30:02 EDT 
+1 works great now, able to close/disconnect/etc from the console and open again later.

I made one small change to close the input stream that writes out the warning message.

Fixed in HEAD.