| Summary: | When assigning Pkg.libTemplate, compile options need extra space padding. | ||
|---|---|---|---|
| Product: | [Technology] RTSC | Reporter: | Chris Ring <cring> |
| Component: | Core | Assignee: | Dave Russo <d-russo> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | sascha |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:3.20 | ||
fixed in
r955 (to be part of xdc-v31)
r956 (to be part of any future 3.16 release)
- verified that the problem as described exists in 3.20.00.35 by adding Pkg.libTemplate and user defined 'defs' for a library. - using 3.20.00.39 adds a space between user-defined defs and the Pkg.libTemplate addition to the command line. |
When assigning a .libTemplate to a package, a new "-D__xdc_bld_pkg_c__=package.bld.c" definition is added to the compile lines. When the user supplies their own compile defs, this -D__xdc_bld_pkg_c__ option is added to the user-supplied definitions without a space between them. In xdc/bld/_gen.xs, I see the following line - only when there is a pkg.libTemplate provided: libAttrs.defs = defs + "-D__xdc_bld_pkg_c__=package.bld.c"; I think we need to add a space before the -D libAttrs.defs = defs + " -D__xdc_bld_pkg_c__=package.bld.c"; A workaround is that the pkg supplying their own defs must add a trailing space to their defs.