Bug 312607

Description meri.web.accounts 2010-05-12 09:09:17 EDT

If validators property reportSuccesses is set to false and no constraint returns failure status (e.g. model is OK with no errors), 
validation returns NO_CONSTRAINTS_EVALUATED error instead of ALL_CONSTRAINTS_PASSED error.

Code snippet:
	IBatchValidator validator = (IBatchValidator)ModelValidationService.getInstance().newValidator(EvaluationMode.BATCH);
	validator.setReportSuccesses(false);
	//all constraints are satisfied
	IStatus status = validator.validate( objects, monitor );
	System.out.println(status);

System output:
	Status OK: org.eclipse.emf.validation code=10 No constraints were evaluated. null

Workaround:
	Wrap returned status into own IStatus class:

class AroundValidationFrameworkBugStatus implements IStatus {
	
	private final IStatus status;

	public AroundValidationFrameworkBugStatus(IStatus status) {
		super();
		this.status = status;
	}

	public IStatus[] getChildren() {
		return status.getChildren();
	}

	//I could hard code constant or do this ...
	@SuppressWarnings("restriction")
	public int getCode() {
		int code = status.getCode();
		if (code==org.eclipse.emf.validation.internal.EMFModelValidationStatusCodes.NO_CONSTRAINTS_EVALUATED)
			return org.eclipse.emf.validation.internal.EMFModelValidationStatusCodes.ALL_CONSTRAINTS_PASSED;
		
		return code;
	}

	public Throwable getException() {
		return status.getException();
	}

	//I could hard code constant or do this ...
	@SuppressWarnings("restriction")
	public String getMessage() {
		if (org.eclipse.emf.validation.internal.EMFModelValidationStatusCodes.ALL_CONSTRAINTS_PASSED==getCode()) {
			return org.eclipse.emf.validation.internal.EMFModelValidationStatusCodes.ALL_CONSTRAINTS_PASSED_MSG;
		}
	
		return status.getMessage();
	}

	public String getPlugin() {
		return status.getPlugin();
	}

	public int getSeverity() {
		return status.getSeverity();
	}

	public boolean isMultiStatus() {
		return status.isMultiStatus();
	}

	public boolean isOK() {
		return status.isOK();
	}

	public boolean matches(int severityMask) {
		return status.matches(severityMask);
	}
	
	
}