Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312600

Summary:	Required property in a Workbench model
Product:	[Eclipse Project] e4	Reporter:	Yves YANG <yves.yang>
Component:	UI	Assignee:	Project Inbox <e4.ui-inbox>
Status:	RESOLVED WORKSFORME	QA Contact:	Eric Moffatt <emoffatt>
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:	stalebug

Description Yves YANG

2010-05-12 08:29:55 EDT

In EMF, the required property is defined lowBound. If the value is >= 1, it is required. This information is very important in tools to determien which properties need to be provided during the creation. 

I have noticed a property (contributionURI in the class Contribution) should be required, but it is not specified. Please list other required properties.

Comment 1 Eric Moffatt

2010-05-17 15:58:09 EDT

Yves, if we were to do this would we still be able to use the various 'xxxFactoryImpl.eINSTANCE.create<xxx>()' methods? Does the generator change these methods to have constructor args? 

If not then the initially created element (say MPart) would be broken under the contract since the 'contributionURI' wouldn't be defined.

Comment 2 Yves YANG

2010-05-17 17:15:27 EDT

(In reply to comment #1)
> Yves, if we were to do this would we still be able to use the various
> 'xxxFactoryImpl.eINSTANCE.create<xxx>()' methods?

Yes. The change of lowBound of eStructureFeature from 0 to 1 doesn't impact the generated Java APIs.  

> Does the generator change these methods to have constructor args? 

Neither. 

> 
> If not then the initially created element (say MPart) would be broken under the
> contract since the 'contributionURI' wouldn't be defined.

Comment 3 Yves YANG

2010-05-18 21:33:12 EDT

Here is the list of features I found, whose lowbound should be 1.

Application Package
====================
ApplicationElement -> elementId
StringToStringMap -> key
Contribution -> contributionURI 

Commands Package
====================
BindingContext -> name 
Command -> commandName
KeyBinding -> command 
Parameter -> name

UI Package
====================
Input -> inputURI
UILable -> label

Menu Package
====================
HandledItem -> command
UILable -> label

Decriptor.Basic Package
====================
PartDescriptor -> contributionURI

Comment 4 Yves YANG

2010-05-18 21:38:58 EDT

(In reply to comment #3)
> Contribution -> contributionURI 
This should be removed from list (ref comment #1 about MPart)

Comment 5 Eclipse Genie

2018-10-29 15:37:28 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 6 Lars Vogel

2019-06-05 07:41:14 EDT

This is a mass change to close all e4 bugs marked with "stalebug" whiteboard.

If this bug is still valid, please reopen and remove the "stalebug" keyword.