Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312544

Summary: [CCombo] Read-only ComboBoxCellEditor throws javascript error in IE
Product: [RT] RAP Reporter: Ivan Furnadjiev <ivan>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: niels.lippke
Version: 1.3   
Target Milestone: 1.3 RC1   
Hardware: All   
OS: All   
URL: http://www.eclipse.org/forums/index.php?t=msg&th=167953&start=0&
Whiteboard:
Attachments:
Description Flags
fix ruediger.herrmann: iplog+

Description Ivan Furnadjiev CLA 2010-05-12 04:31:52 EDT 
Steps to reproduce:
1. Change Controls Demo -> TableViewerTab#LastNameEditingSupport, line 284 to SWT.READ_ONLY to make the ComboBoxCellEditor in read-only mode.
2. Start in IE the Controls Demo - TableViewerTab and activate the cell editors.
3. Try to edit the second column - javascript error appears: Invalid argument.
See the newsgroup post for more details. The suspicion is the FocusIndicator, which tries to apply negative values (bounds) on the DOM in IE.
Comment 1 Ivan Furnadjiev CLA 2010-05-12 04:58:41 EDT 
*** Bug 312549 has been marked as a duplicate of this bug. ***
Comment 2 Tim Buschtoens CLA 2010-05-12 05:49:12 EDT 
Created attachment 168106 [details]
fix

Fix for FocusIndicator.js.

This solution should work, but is not entirely satisfying for several reasons:

1. The method to find out the "future" dimension of the widget (getBoxWidth/Height) is tedious and error-prone (as has just been proven). An alternative would be preferable.

2. Its unclear to me why i need to invalidate the dimensions after i got them - there should be no changes after the focus indicator is applied, AND qooxdoo should be smart enough to recompute them in the job-queue. Still, it breaks the layout if i don't.

3. We can currently write no useful tests for FocusIndicator because it directly uses the themeStore to get its values.
Comment 3 Rüdiger Herrmann CLA 2010-05-12 09:05:58 EDT 
Applied patch to CVS HEAD