Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312512

Summary: [JSF2.0] Facelet tag registry does not update when jars containing .taglib.xml are added/removed from the classpath
Product: [WebTools] Java Server Faces Reporter: Cameron Bateman <cameron.bateman>
Component: CoreAssignee: Cameron Bateman <cameron.bateman>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: cameron.bateman, kaloyan, raghunathan.srinivasan
Version: 3.2Flags: cameron.bateman: pmc_approved?
raghunathan.srinivasan: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved? (naci.dai)
raghunathan.srinivasan: pmc_approved? (deboer)
raghunathan.srinivasan: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
raghunathan.srinivasan: review+
Target Milestone: 3.2 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard: JSF2.0 PMC_approved
Attachments:
Description Flags
Adds a classpath listener mechanism that causes the FaceletTagRegistry to respond to jars being added and removed from the classpath
none
Test coverage for changes none

Description Cameron Bateman CLA 2010-05-11 18:09:42 EDT
The tag registry was not listening for changes on the classpath that added jar files.  For example, if you drop a jar file with .taglib.xml files into WEB-INF/lib or remove them, it was not detecting these conditions.
Comment 1 Cameron Bateman CLA 2010-05-11 18:11:26 EDT
Created attachment 168059 [details]
Adds a classpath listener mechanism that causes the FaceletTagRegistry to respond to jars being added and removed from the classpath
Comment 2 Cameron Bateman CLA 2010-05-11 18:13:09 EDT
Created attachment 168060 [details]
Test coverage for changes
Comment 3 Raghunathan Srinivasan CLA 2010-05-11 19:45:41 EDT
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
The defect results in the tool not recognizing the addition or removal of composite components that are packaged in Jars. This will frustrate the end-user since they won't be able to use the components that they have added in the current session.
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
The workaround is to re-start the workbench or close and open the project
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
The patch includes a comprehensive set of Junit tests
* Give a brief technical overview. Who has reviewed this fix? 
See comment 1
* What is the risk associated with this fix?
Medium.
Comment 4 Cameron Bateman CLA 2010-05-12 11:27:01 EDT
Patches applied to HEAD (3.2RC1).
Comment 5 Cameron Bateman CLA 2010-05-12 11:27:13 EDT
Fixed.