Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312467

Summary: TVT36:TCT140: CHS: Different Error Message
Product: [Tools] CDT Reporter: CDE Administration <cdeadmin>
Component: cdt-debug-dsf-gdbAssignee: Marc Khouzam <marc.khouzam>
Status: CLOSED FIXED QA Contact: Marc Khouzam <marc.khouzam>
Severity: normal    
Priority: P3 CC: aleherb+eclipse, camle, kitlo, marc.khouzam, pawel.1.piech, vivkong
Version: 7.0Flags: vivkong: review+
aleherb+eclipse: review+
Target Milestone: 7.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
140_06.000.380_different_err_msg.gif
none
06.000.380.gif
none
140_DE_CDT_06.000.380_enStr.gif
none
Fix
marc.khouzam: iplog-
TCT140_build20100513.gif
none
Fix for string "Debug Current Instruction Pointer"
marc.khouzam: iplog-
untranslated.png
none
index.png none

Description CDE Administration CLA 2010-05-11 13:06:37 EDT 
<response_by> Ma Xiao Long at 2010.05.04.08.27.05 </response_by>
NLS Build Label: 20100426-1300-nl1
Language: S.Chinese

- Steps To Recreate Problem:
Please make sure you have completed the steps in CDT Prerequisite Setup before beginning any other section

Select project_import from the Project Explorer
Right-click the project and select Debug as > Debug Configurations
Double-click C/C++ Application
Click  Debug
In the Confirm Perspective Switch dialog, click Yes
In the Debug perspective, go to Window > Customize Perspective
Under Command Groups Availability check the box next to C/C++ Tracepoints
Click Ok to exit from dialog
If main.cpp is not opened, In the Project Explorer, double click main.cpp under project_import to open main.cpp editor.
Right click in the left hand margin of the editor, and select Breakpoint Types > C/C++ Tracepoints
Double click in the left hard margin of the editor, beside line 19
Hover over the warning and verify

- Problem Description:
We found an English error message but it is not expected one, pls help to check, thanks!

<response_by> Mostafa Ali at 2010.05.05.08.52.19 </response_by>
Hi,

Same for Arabic.

Thanks
Mostafa Ali

<response_by> nguyer at 2010.05.05.09.35.39 </response_by>
I have done some investigation on this string, and it appears that this is a new string. It should have been included in the last PII shipment, and should be translated in future builds. I will also update the test case to use the new string, rather than the old one.

Thanks!

- Nicko

<response_by> Moravia IT at 2010.05.06.06.55.58 </response_by>
Same for PLK.

Regards,
Maciek

<response_by> maria cristina caroletti at 2010.05.06.11.16.55 </response_by>
In It version "breakpoint attribute problem: installation failed"
is untranslated.
Please advise.
Thanks
Alessandro

<response_by> Holger Schicht at 2010.05.06.11.38.48 </response_by>
Hi,

Same problem for German.

Thanks,
Holger

<response_by> martine marin at 2010.05.06.12.33.54 </response_by>
Same for France
Martine

<response_by> Manuel Ferro at 2010.05.06.14.39.33 </response_by>
Same problem for PTG.

Regards,
Ricardo

<response_by> nguyer at 2010.05.06.15.46.18 </response_by>
Changing status to Working

<response_by> Kathy Li at 2010.05.11.11.48.26 </response_by>
This article was reassigned from Category:''TVT/Testing,Inbox''.

<response_by> Kathy Li at 2010.05.11.11.50.29 </response_by>
Must-Fix: Yes

I have done initial search and this string is not included in any PII shipment, please invetigate.

the string is :
Breakpoint attribute problem: installation failed
Comment 1 CDE Administration CLA 2010-05-11 13:06:51 EDT 
Created attachment 167973 [details]
140_06.000.380_different_err_msg.gif
Comment 2 CDE Administration CLA 2010-05-11 13:06:55 EDT 
Created attachment 167974 [details]
06.000.380.gif
Comment 3 CDE Administration CLA 2010-05-11 13:06:57 EDT 
Created attachment 167975 [details]
140_DE_CDT_06.000.380_enStr.gif
Comment 4 CDE Administration CLA 2010-05-11 13:07:06 EDT 
<cde:tctdetail>
Testcase: 06.000.380 - CDT - DEBUG CONFIGURATIONS
Project: WSW36
Component: Xfer - CDT/cdt-debug
Priority: 2
Subject: CHS: Different Error Message
Article ID: 140
Originator: maxl@szchkj.com.cn
</cde:tctdetail>
Comment 5 Marc Khouzam CLA 2010-05-11 13:23:08 EDT 
The string "Breakpoint attribute problem: installation failed" is hard-coded by mistake in org.eclipse.cdt.dsf.mi.service.MIBreakpointsManager
Comment 6 Marc Khouzam CLA 2010-05-11 13:26:43 EDT 
> - Problem Description:
> We found an English error message but it is not expected one, pls help to
> check, thanks!

Depending on the cause of the error, we sometimes display
"Breakpoint attribute problem: installation failed"
but other times
"Tracepoints are not supported"

So, I think having different error messages is ok.
But the string "Breakpoint attribute problem: installation failed" should not be in english see comment #5
Comment 7 Vivian Kong CLA 2010-05-11 14:43:23 EDT 
(In reply to comment #5)
> The string "Breakpoint attribute problem: installation failed" is hard-coded by
> mistake in org.eclipse.cdt.dsf.mi.service.MIBreakpointsManager

Hi Marc, will you be providing a fix for this?
Comment 8 Marc Khouzam CLA 2010-05-11 21:38:55 EDT 
Created attachment 168070 [details]
Fix

Here is the fix.  I committed it to HEAD.
Vivian can you confirm this looks ok?
Comment 9 Marc Khouzam CLA 2010-05-11 21:39:48 EDT 
Vivian can you review?
Comment 10 Vivian Kong CLA 2010-05-12 09:55:12 EDT 
Looks good.  Thanks Marc
Comment 11 CDE Administration CLA 2010-05-13 03:51:15 EDT 
<response_by> Keiko Terada at 2010.05.13.02.41.18 </response_by>
verified fix in 20100512-1300 for JA, thanks!
Comment 12 CDE Administration CLA 2010-05-14 00:21:09 EDT 
<response_by> Ma Xiao Long at 2010.05.13.23.17.50 </response_by>
I checked in build 20100512-1300-nl1, and the English string is still there.
Comment 13 CDE Administration CLA 2010-05-14 14:21:15 EDT 
<response_by> martine marin at 2010.05.14.13.19.17 </response_by>
Not fixed for France as well.
See attached capture
Thanks,
Martine
Comment 14 CDE Administration CLA 2010-05-14 14:21:19 EDT 
Created attachment 168574 [details]
TCT140_build20100513.gif
Comment 15 Marc Khouzam CLA 2010-05-14 14:33:55 EDT 
(In reply to comment #14)
> Created an attachment (id=168574) [details]
> TCT140_build20100513.gif

The only file I can see the string "attribute problem" or "installation failed" is org.eclipse.cdt.dsf.mi.service.Messages.properties.  Maybe it was not translated?

As for "Debug Current Instruction Pointer", I did find it hard-coded in org.eclipse.cdt.dsf.debug.ui.sourcelookup.InstructionPointerManager, which also contains the string "Debug Call Stack".  I'll write a patch for that.
Comment 16 Marc Khouzam CLA 2010-05-14 14:42:15 EDT 
Created attachment 168579 [details]
Fix for string "Debug Current Instruction Pointer"

Fix for "Debug Current Instruction Pointer" and "Debug Call Stack"

Committed to HEAD.
Do I have to do anything to get these new strings translated?
Comment 17 Marc Khouzam CLA 2010-05-14 14:42:50 EDT 
Toni, can you confirm that this string handling is ok?
Comment 18 Anton Leherbauer CLA 2010-05-17 03:02:07 EDT 
(In reply to comment #17)
> Toni, can you confirm that this string handling is ok?

Thanks for fixing it.
Comment 19 CDE Administration CLA 2010-05-19 14:52:21 EDT 
<response_by> nguyer at 2010.05.19.13.48.28 </response_by>
I just checked the most recent CDT build that I have (201005141611) and it appears to be using the old error message again, which is rather confusing to me. However, only two of the lines is translated, and the other is in English. Please see the attached screenshot of CDT 201005141611 running in Hungarian.

Thanks!

- Nicko
Comment 20 CDE Administration CLA 2010-05-19 14:52:26 EDT 
Created attachment 169187 [details]
untranslated.png
Comment 21 Marc Khouzam CLA 2010-05-19 15:13:23 EDT 
(In reply to comment #19)
> <response_by> nguyer at 2010.05.19.13.48.28 </response_by>
> I just checked the most recent CDT build that I have (201005141611) and it
> appears to be using the old error message again, which is rather confusing to
> me. 

What error message is that?  I think it is the second line in the screenshot, which is in Hungarian so I don't understand it :-)

> However, only two of the lines is translated, and the other is in English.

I don't understand why this one is in English.  The only place I've see this string is in org.eclipse.cdt.debug.internal.core.breakpoints.BreakpointMessages.properties so it should be translated.

Do we need to do something else to get it translated?
Comment 22 CDE Administration CLA 2010-05-20 16:51:13 EDT 
<response_by> nguyer at 2010.05.20.15.35.38 </response_by>
This is the "Multiple markers at this line" warning message. It comes from eclipse/plugins/org.eclipse.cdt.ui/org/eclipse/cdt/internal/ui/CUIMessages.properties.

I have attached a new screenshot (in English) running a special build of Eclipse that puts an index in front of every externalized string so that its source can be looked up in a table. In the screenshot i have outlined each index in green. Each line begins with an externalized string.

The second two lines begin with a generic indentation string which comes from eclipse/plugins/org.eclipse.jface.text/org/eclipse/jface/internal/text/html/HTMLMessages.properties

After the indentation, the third line has another string that comes from eclipse/plugins/org.eclipse.cdt.debug.core/org/eclipse/cdt/debug/internal/core/breakpoints/BreakpointMessages.properties

However, notice how the second line has no index after the indentation. This means that the string is not externalized, and is likely hardcoded into the software somewhere.

Hopefully this is helpful information in tracking down the string that must be externalized. After it is externalized it can be translated.

Thanks!

- Nicko
Comment 23 CDE Administration CLA 2010-05-20 16:51:17 EDT 
Created attachment 169419 [details]
index.png
Comment 24 Marc Khouzam CLA 2010-05-21 11:28:57 EDT 
(In reply to comment #19)
> <response_by> nguyer at 2010.05.19.13.48.28 </response_by>
> I just checked the most recent CDT build that I have (201005141611) and it
> appears to be using the old error message again, which is rather confusing to
> me. 

Ok, I get it now.  The error message depends on which debugger integration you are using.  If you use DSF-GDB you will see
  "Breakpoint attribute problem: installation failed"
but if you use CDI you will see:
  "Tracepoints are not supported"

The reason is that the new Tracepoint feature is only supported with DSF-GDB.

> However, only two of the lines is translated, and the other is in English.
> Please see the attached screenshot of CDT 201005141611 running in Hungarian.

I figured out that any existing breakpoint will keep it's old marker string.  Can you create a new tracepoint and see if you see the string properly translated?  If you still see it in English, then can you hover over a breakpoint and let me know where the "Line breakpoint:" string is defined so I can try to figure out why it is not working for tracepoints.

Thanks
Comment 25 CDE Administration CLA 2010-05-21 21:20:48 EDT 
<response_by> Ma Xiao Long at 2010.05.21.20.19.29 </response_by>
Fixed for CHS in build 20100520-0200-nl1, thanks!
Comment 28 CDE Administration CLA 2010-07-28 15:59:44 EDT 
<response_by> Eric Ma at 2010.05.04.08.27.05 </response_by>

































<response_by> Eric Ma at 2010.05.13.23.17.50 </response_by>

































<response_by> Eric Ma at 2010.05.21.20.19.29 </response_by>