Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312466

Summary: early call to modify bundle root leaves WorkspacePluginModelManager un-initialized
Product: [Eclipse Project] PDE Reporter: Darin Wright <darin.eclipse>
Component: UIAssignee: Darin Wright <darin.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: curtis.windatt.public, makandre
Version: 3.6Flags: curtis.windatt.public: review+
Target Milestone: 3.6 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch none

Description Darin Wright CLA 2010-05-11 12:56:26 EDT
It's possible to use the IBundleProjectService to set the root of a bundle. If this is done before the PDE model managers are initialized, it can leave the WorkspacePluginModelManager in an un-initialized state.

It results in a call to 'removeModel(...)', and 'createModel(...)', which will quietly initlaize 'fModels' to a hashtable, and the next call to 'initialize()' will be ignored since 'fModels' is no longer null. The result is that the model manager is not hooked up to listen to resource deltas.
Comment 1 Darin Wright CLA 2010-05-11 12:57:16 EDT
Created attachment 167972 [details]
patch
Comment 2 Darin Wright CLA 2010-05-11 13:11:50 EDT
Please review, Curtis.
Comment 3 Curtis Windatt CLA 2010-05-11 14:13:55 EDT
+1 Fixed in HEAD.