Bugzilla – Full Text Bug Listing
| Summary: | Improve usability of BND within build system | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Tom Ware <tom.ware> | ||||||
| Component: | Eclipselink | Assignee: | Nobody - feel free to take it <nobody> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | david.twelves, tom.ware | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Tom Ware
I was trying to do the latter, but am running into some limitations with ant. I think I'll need to write a custom task or javascript task to do this. In the interim, will modify the searches to look for specific versioned jar, and if not found look for a bnd.jar in one of the two dirs. that way users won't have to modify thebuild, they could just rename a bnd jar file. Working on an ant task that will load a found jar like OSGi does (with version criteria) since jarnames change with each build, and ideally all these checks should be automatic so we can move directly to to automated orbit dependencies, as well as providing flexability to bnd checks and other processes. Created attachment 172353 [details]
ant extensions project - conditional messaging, and OSGi-like bundle selection
the following zip contains five (5) classes and two (2) ant buildfiles.
in the helper package is the version and version exception classes (sts define an OSGi version object), and a test class to validate them.
under taskdef are the two custom ant tasks:
selectBundle - determines the filename of the 'best' filename match for a bundle given OSGi-like matching criteria
Say - a conditional Echo
antbuild.xml - builds the cutomizations jar.
the test.xml loads the tasks and them.
Some means to do this is necessary to both find the most appropriate bnd, but also to use when generating features, as well as identifying current jar dependencies from orbit, etc.
Looks good Created attachment 172592 [details]
minor cleanup of compile cp to remove unused jars.
obseletes the antbuild.xml file within the attached zip.
Code looks OK to me after the removal of the unused jars in antbuild.xml Spoke with Peter about an additional review. He says two is enough especially since the contribution won't have any impact upon the build or other components. Based upon his recommendation and the two reviews I am merging to trunk. Once complete, I will begin working on changing the BND detection code to dynamically determine the bnd jar (rather than use a hard-coded default). This should have been marked resolved long ago. The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink |