Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312405

Summary: PublishJob could be more thread safe
Product: [WebTools] WTP ServerTools Reporter: Gary Karasiuk <karasiuk>
Component: wst.serverAssignee: Angel Vera <arvera>
Status: RESOLVED FIXED QA Contact: Angel Vera <arvera>
Severity: normal    
Priority: P2    
Version: 3.2   
Target Milestone: 3.2.2   
Hardware: PC   
OS: Windows XP   
See Also: https://git.eclipse.org/r/108981
Whiteboard:
Attachments:
Description Flags
example of making things safer arvera: iplog+, arvera: review+

Description Gary Karasiuk CLA 2010-05-11 08:14:19 EDT 
I was looking at PublishJob for other reasons, and I have some suggestions for making it a little more thread safe.

See the attached patch. 

This patch is just an example, of things that you should be considering when running code in a different thread. (I didn't load all your plug-ins to see if you ever subclass this class).

I'm not suggesting that this be changed for 3.2.
Comment 1 Gary Karasiuk CLA 2010-05-11 08:14:54 EDT 
Created attachment 167902 [details]
example of making things safer
Comment 2 Angel Vera CLA 2010-05-11 08:49:01 EDT 
This seems like a good suggestion, I will check on it for the next release
Comment 3 Angel Vera CLA 2010-08-23 14:39:23 EDT 
changes committed to 32M
Comment 4 Angel Vera CLA 2010-08-23 17:22:19 EDT 
Changes committed and released to 32M and HEAD(3.3)
Comment 5 Angel Vera CLA 2010-08-24 14:16:44 EDT 
Fixed.
Comment 6 Eclipse Genie CLA 2017-10-11 16:34:24 EDT 
New Gerrit change created: https://git.eclipse.org/r/108981