| Summary: | TVT36:TCT209: JPN: Missing Attach button on New Tracepoint Action dialog | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | CDE Administration <cdeadmin> | ||||||||
| Component: | cdt-debug-dsf-gdb | Assignee: | Marc Khouzam <marc.khouzam> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | Marc Khouzam <marc.khouzam> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | camle, kitlo, pawel.1.piech, vivkong | ||||||||
| Version: | 7.0 | Flags: | vivkong:
review+
|
||||||||
| Target Milestone: | 7.0 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows 7 | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
CDE Administration
Created attachment 167827 [details]
06.000.228.gif
<cde:tctdetail> Testcase: 06.000.228 - CDT - C/C++ PREFERENCES Project: WSW36 Component: Xfer - CDT/cdt-build Priority: 2 Subject: JPN: Missing Attach button on New Tracepoint Action dialog Article ID: 209 Originator: terak@jp.ibm.com </cde:tctdetail> The window is too small. If you make the window larger from the bottom, the buttons will become visible. Created attachment 167933 [details]
screenshot
You need to make the dialog bigger. Here's what it should look like and the Attach button is there
Resize the dialog and the button will appear. I believe the reporter saw the problem when the dialog was launched in its default size. There is no indication that the dialog is not big enough (like scroll bars or "...' or anything). I'm afraid the some users may not know that we have to resize the dialog to see the buttons. Is there any way to make the default size bigger? <response_by> Keiko Terada at 2010.05.11.19.11.36 </response_by> Since OK and Cancel buttons are shown, users will see the diqalog is enough big to see whole contents. As kit commented, users may not notice to resize the dialog. Could you expand the height of the dialog? (In reply to comment #7) > <response_by> Keiko Terada at 2010.05.11.19.11.36 </response_by> > Since OK and Cancel buttons are shown, users will see the diqalog is enough big > to see whole contents. As kit commented, users may not notice to resize the > dialog. > > Could you expand the height of the dialog? Ok, I'll write a fix for that Created attachment 168168 [details]
Fix to resize the window to make sure buttons are all visible
Thsi patch resizes the window to make sure buttons are all visible.
Committed to HEAD.
Vivian can you review? Looks good. Thanks Marc. <response_by> rewagner at 2010.05.12.15.22.58 </response_by> Testers: Please verify and close thread if fix worked in new build. <response_by> Keiko Terada at 2010.05.13.00.28.47 </response_by> I will verify in the new build after 20100512-1300 as it does not contain the fix yet. <response_by> Keiko Terada at 2010.05.14.03.37.07 </response_by> I verified the fix in 20100513-1500. Thanks! *** cdt cvs genie on behalf of mkhouzam *** Bug 312342: Make sure the dialog window size is big enough to show all its content. [*] TracepointActionDialog.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/tracepointactions/TracepointActionDialog.java?root=Tools_Project&r1=1.1&r2=1.2 [Added by CDE: Completed by the CDE Bridge] |