Bugzilla – Full Text Bug Listing
| Summary: | TVT36:TCT199: Mnemonics on TestConnection context menu are inconsistent with Eclipse Platform | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] Target Management | Reporter: | CDE Administration <cdeadmin> | ||||||||
| Component: | RSE | Assignee: | Martin Oberhuber <mober.at+eclipse> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||||||
| Severity: | trivial | ||||||||||
| Priority: | P5 | CC: | camle, kitlo, xuanchen | ||||||||
| Version: | 3.2 | Keywords: | PII | ||||||||
| Target Milestone: | 3.2 RC1 | Flags: | xuanchen:
review+
|
||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows 7 | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
CDE Administration
Created attachment 167782 [details]
14.000.230-UnableToGetUniqueMnemonics.gif
<cde:tctdetail> Testcase: 14.000.230 - RSE - MENUS Project: WSW36 Component: Xfer - Target Management/RSE Priority: 3 Subject: FRA - Unable to get unique mnemonics on TestConnection context menu Article ID: 199 Originator: mmarin@fr.ibm.com </cde:tctdetail> Changed summary, previous value was:
TVT36:TCT199: FRA - Unable to get unique mnemonics on TestConnection context menu
First of all, duplicate menmonics in non-English RSE would not be an Open Source issue but a problem for the company proviging translations. In this case, what matters is that the same problem exists in the English version of RSE, so I'm accepting the case.
Second, duplicate menmonics are usually not an issue -- just typing the mnemonic char twice works just fine. What's most important is that mnemonics are deterministic (always the same), which doesn't seem the case here (In one instance I have seen "Monitor" both with an "M" mnemonic and with a "T" mnemonic).
In general, because Eclipse is Open to extensions, there is no way guaranteeing consistent, deterministic, non-conflicting mnemonics everywhere. The one thing that can be done is assigning a fixed mnemonic for often-used actions which appear in multiple different, unrelated menus. Assigning too many fixed mnemonics again is a recipe for conflicts in other places.
In the concrete case, the only useful change that I could see would be
1.) Change Mnemonic for "Move up" from (V) to (U) -- direction ("up") matters
2.) Change Mnemonic for "Move" from (O) to (V) -- same as File>Move
3.) Change Mnemonic for "Monitor" from (M) to (O) or (T), or keep unassigned
As you see, assignment of mnemonics is tricky and there is good chance that one change in a place introduces conflicts in another place. I'm not even sure whether a change to PII for such a minor issue is acceptable that late in the game (we are at RC1).
Created attachment 167906 [details]
Patch v1
Attached patch fixes
Move Up --> Move &Up
Move --> Mo&ve
Go Into --> Go &Into
Monitor --> Moni&tor
Since these are all default hard-coded mnemonics also found in Eclipse Platform:
messages.properties - org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/framelist
and thus make the RSE view consistent with other Eclipse views.
I changed the summary again, since I believe the most important fix of my patch is making mnemonics consistent with the Eclipse Platform (which should also make translation easier, at least for Babel). Xuan please let me know whether this fix (which affects PII) is acceptable for 3.2RC1. Thanks for looking into this, Martin. I checked the NL schedule, and we still have time to make PII changes. Thanks. Committed for 3.2RC1. I'm sure that there are many similar cases since none of the labels in SystemResources.properties use any hard-coded mnemonics today. But I don't have time to review all of them for consistency with Eclipse Platform labels / mnemonics. <response_by> Kathy Li at 2010.05.25.11.09.51 </response_by> Hi Xuan, any update on this one? Any plan to fix the issues? Thanks Kathy Look at the status. It is fixed as per TM 3.2rc1. <response_by> Kathy Li at 2010.05.25.13.56.15 </response_by> Thank you for the confirmation, we'll ask countries to verify. <response_by> martine marin at 2010.05.27.11.34.17 </response_by> Hi, This is impossible to get them all unique. For Properties since there is a workaround Alt+Enter I guess it's OK to have it duplicate. When you have more than 15 items it is really impossible to fix all mnemonics, for Monitor, all the letters are already taken for instance. Verified with build 20100526-1600 Thanks, Martine Created attachment 170220 [details]
TCT199_mnemo.gif
Why do you reopen when you write it's verified? <response_by> Kathy Li at 2010.05.28.10.19.00 </response_by> I'm closing it as it's verified by FR. [Added by CDE: Completed by the CDE Bridge] |