Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312307

Summary:

[validation] ValidatorStrategy triggering unwanted plug-in activation

Product:

[WebTools] WTP Source Editing

Reporter:

Nick Sandonato <nsand.dev>

Component:

wst.sse

Assignee:

Nick Sandonato <nsand.dev>

Status:

RESOLVED FIXED

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

major

Priority:

CC:

ccc, karasiuk, nsand.dev, valentinbaciu

Version:

3.0.3

Keywords:

performance

Target Milestone:

3.0.5 P

Flags:

thatnitind: review+

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none

Description Nick Sandonato

2010-05-10 13:29:12 EDT

+++ This bug was initially created as a clone of Bug #262151 +++

The org.eclipse.wst.sse.ui.internal.reconcile.validator.ValidatorStrategy in the reconcile method is calling an internal validation framework method:

IValidator iv = v.asIValidator();

This call triggers that validator's plug-in to be activated. Since this is being called on all the disabled validators, it is causing all the validation plug-ins to load.

If I provided you with a method, so that you could first tell if the validator was activated, could you make use of it to not call this asIValidator() ?

Comment 1 Nick Sandonato

2010-05-10 13:51:24 EDT

Created attachment 167768 [details]
patch

This patch removes code that would cause activation of plug-ins due to instantiating Validators.

Comment 2 Nick Sandonato

2010-05-10 13:51:42 EDT

Nitin, could you please review for 3.0.5p?

Comment 3 Carl Anderson

2010-05-21 08:33:07 EDT

Committed to R3_0_5_patches