Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312278

Summary:

[performance] Opening the LCD is slow

Product:

[Eclipse Project] PDE

Reporter:

Darin Wright <darin.eclipse>

Component:

Assignee:

Darin Wright <darin.eclipse>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ankur_sharma, curtis.windatt.public

Version:

3.6

Keywords:

performance

Target Milestone:

3.6 RC2

Flags:

curtis.windatt.public: review+
ankur_sharma: review+

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

309884, 313388

Attachments:

Description	Flags
patch	none
update	none

Description Darin Wright

2010-05-10 11:26:50 EDT

Opening the LCD for Eclipse applications seems slow again. I have a case where I'm using feature based launch with 400+ features, and opening the LCD takes about 15 seconds. 

Also, typing/changing the "name" field of a configuration seems slow.

Needs investigation.

Comment 1 Darin Wright

2010-05-14 13:45:30 EDT

I filed bug 312949 for the issue with typing in the name field (which is a platform bug). Typing in the Eclipse Application fields seems fine, however, opening the LCD on an Eclipse Application, and switching between them is slow.

Comment 2 Darin Wright

2010-05-14 14:49:32 EDT

Created attachment 168582 [details]
patch

Using YourKit, I found that 50% of the time switching to a feature based launch is due to the fact that the feature block creates new workspace/external feature model managers each time it is used. It's much faster to re-use the existing managers from PDE.

Comment 3 Darin Wright

2010-05-14 14:53:17 EDT

Created attachment 168583 [details]
update

Forgot to include the change in pde.core as well.

Comment 4 Curtis Windatt

2010-05-18 09:43:51 EDT

+1, waiting for Ankur's review.  Looks like he wasn't cc'd, so he may have missed the review request.

Comment 5 Ankur Sharma

2010-05-18 12:00:13 EDT

+1

We need to make these changes in BundleLauncherHelper.getMergedBundleMap also. Is there a bug for it already?

Comment 6 Curtis Windatt

2010-05-18 12:25:22 EDT

Fixed in HEAD.

Comment 7 Curtis Windatt

2010-05-18 12:30:32 EDT

I removed the fmm.shutdown() line just after where we get the feature model manager.  It only removes the listeners, but we shouldn't be doing that to the default model manager.

Comment 8 Darin Wright

2010-05-21 11:22:56 EDT

Verified.