Bugzilla – Full Text Bug Listing
| Summary: | [expression view][delta] Missing delta for expressions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Marc Khouzam <marc.khouzam> | ||||
| Component: | cdt-debug-dsf | Assignee: | Marc Khouzam <marc.khouzam> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Pawel Piech <pawel.1.piech> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ed.swartz, pawel.1.piech | ||||
| Version: | 6.0 | Flags: | pawel.1.piech:
review+
ed.swartz: review+ |
||||
| Target Milestone: | 7.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Pawel, can you ok this fix before I commit? Ed, can you confirm that removing the call to refresh() is ok? Works for me in EDC. Yes, this makes sense. Thanks Marc. Committed to HEAD. *** cdt cvs genie on behalf of mkhouzam *** Bug 312229: Missing delta generation was forcing us to refresh the expressions view needlessly. [*] DsfCastToTypeSupport.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/DsfCastToTypeSupport.java?root=Tools_Project&r1=1.2&r2=1.3 [*] VariableVMNode.java 1.18 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/variable/VariableVMNode.java?root=Tools_Project&r1=1.17&r2=1.18 |
Created attachment 167674 [details] Fix I noticed that the new "cast to type" dsf feature would do a full view refresh() whenever an expression was casted. This seemed excessive, but removing it prevented to the view from showing the change. I tracked it down to a missing delta in VariableVMNode. This patch fixes the missing delta and removes the refresh() call.