Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312199

Summary: [metadata] Match expression of update descriptor not persisted as such
Product: [Eclipse Project] Equinox Reporter: Pascal Rapicault <pascal>
Component: p2Assignee: Thomas Hallgren <thomas>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 Flags: pascal: review+
Version: 3.6   
Target Milestone: 3.6 RC1   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Bug Depends on:    
Bug Blocks: 311269    
Attachments:
Description Flags
Partial patch
none
Patch with reader side implemented none

Description Pascal Rapicault CLA 2010-05-09 22:03:34 EDT
Persisting match expressions from the update descriptors fail if the match is not a RequiredCapability.
Comment 1 Pascal Rapicault CLA 2010-05-09 22:08:23 EDT
Created attachment 167646 [details]
Partial patch

Thomas, here is a test showing the problem and a partial patch dealing with the writing aspect of things. Could you please take care of the reading part of this? Thx.
Comment 2 Thomas Hallgren CLA 2010-05-11 02:43:04 EDT
Your patch suggests that the severity and description are discarded unless a simple requirement is used. I would have thought that the requirement only replaces the name and range and that the severity and description should be serialized regardless. Can you please explain?
Comment 3 Thomas Hallgren CLA 2010-05-11 03:16:39 EDT
Created attachment 167868 [details]
Patch with reader side implemented

This patch does the following:

1. changes the behavior from the previous patch so that the writer
    side so that the description and severity is serialized always.
2. Implements the reader site.
3. Fixed the names of the affected IU's in the test.

The test is now green.
Comment 4 Pascal Rapicault CLA 2010-05-11 14:57:30 EDT
Patch released.