Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312192

Summary: PDE Extension editor unreliable in 3.6
Product: [Eclipse Project] PDE Reporter: Ralf Ebert <ralf>
Component: UIAssignee: PDE-UI-Inbox <pde-ui-inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: critical    
Priority: P3 CC: caniszczyk
Version: 3.6   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
elements_duplicated_1.png
none
elements_duplicated_2.png
none
xml_broken.png
none
MalformedTreeException.txt
none
ext1.png
none
ext2.png none

Description Ralf Ebert CLA 2010-05-09 17:59:31 EDT
Eclipse SDK 3.6.0.I20100504-0800

While manipulating extension elements (adding/removing elements and changing attributes) in the PDE Extension Editor, these errors occur frequently, making the editor unusable:

- Whole elements (extension element and sub-elements as well) get duplicated, see attached screenshots elements_duplicated_1.png (I only created one menus/commands/handlers element, the rest appeared upon reopening the document) and elements_duplicated_2.png (every change seems to have caused one duplicate element, the editing history can be seen from bottom to top)
- XML text fragments are inserted in the wrong places, screwing up the whole document (see xml_broken.png, '</plu' in the middle and 'gin>' at the end)
- MalformedTreeException exception, see attachment MalformedTreeException.txt.
Comment 1 Ralf Ebert CLA 2010-05-09 18:00:22 EDT
Created attachment 167636 [details]
elements_duplicated_1.png
Comment 2 Ralf Ebert CLA 2010-05-09 18:00:52 EDT
Created attachment 167637 [details]
elements_duplicated_2.png
Comment 3 Ralf Ebert CLA 2010-05-09 18:01:09 EDT
Created attachment 167638 [details]
xml_broken.png
Comment 4 Ralf Ebert CLA 2010-05-09 18:01:25 EDT
Created attachment 167639 [details]
MalformedTreeException.txt
Comment 5 Chris Aniszczyk CLA 2010-05-09 18:02:36 EDT
How are you reproducing this?

Can you give us a simple set of steps... we don't really touch the editing bits of PDE much so it could be something that bubbled up from JFace Text...
Comment 6 Ralf Ebert CLA 2010-05-09 19:00:16 EDT
Problem number 1 (duplicated elements) seems to be triggered by having the WTP XML tooling installed. I could swear I have seen a bug related to that, but I cannot find it.

I can reproduce this using the following steps:

- Create a new plug-in, contributing to the UI, no template.
- Go to extensions (should be empty)
- Add "org.eclipse.ui.commands", Save.
- Add a command element and Save.
- Add another command element and Save, should look like ext1.png now.
- Reopen the document, looks like ext2.png.


- Reproduced on my Eclipse SDK 3.6.0.I20100504-0800 installation.
- Updated to Eclipse SDK 3.6.0.I20100509-0800, still reproducable.
- Tried the same on a fresh Eclipse SDK M7 installation, works as expected.
- Updated to 3.6.0.I20100509-0800, works as expected.
- Installed XML tooling from latest WTP I-Build (http://download.eclipse.org/webtools/downloads/drops/R3.2.0/I-3.2.0-20100422162836/repository/):

Eclipse Web Developer Tools	3.2.0.v201004210707-7O7BFb3EMf6XlkhHH1z00lDAbWVW
Eclipse XML Editors and Tools	3.2.0.v201004210707-7H7AFRADxumKhLR7fb2JMe9ejpDV

Problem reproducable again.

Will try to reproduce the other problems tomorrow.
Comment 7 Ralf Ebert CLA 2010-05-09 19:01:23 EDT
Created attachment 167642 [details]
ext1.png
Comment 8 Ralf Ebert CLA 2010-05-09 19:01:59 EDT
Created attachment 167643 [details]
ext2.png
Comment 9 Chris Aniszczyk CLA 2010-05-09 19:37:14 EDT
I'm guessing this is a dupe of bug 307524.

That one should probably be bumped to critical.

*** This bug has been marked as a duplicate of bug 307524 ***