Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312181

Summary:	The M7 milestone repository contains corrupt pack200 files.
Product:	[Eclipse Project] Platform	Reporter:	Thomas Hallgren <thomas>
Component:	Releng	Assignee:	Kim Moir <kim.moir>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3	CC:	david_williams, filip.hrbek, kim.moir
Version:	3.6
Target Milestone:	3.6 RC1
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	312149

Description Thomas Hallgren

2010-05-09 08:56:43 EDT

The following files appear to be corrupt. The verifier consider them "tampered" after unpack.

org.eclipse.core.runtime.CoreException: Unable to unpack artifact osgi.bundle,org.eclipse.pde.api.tools,1.0.201.v20100428-1300 in repository file:/home/shared/helios/buildresults/final/aggregate: Invalid content:org/eclipse/pde/api/tools/internal/provisional/Factory.class
Caused by: org.eclipse.osgi.signedcontent.InvalidContentException: The file "org/eclipse/pde/api/tools/internal/provisional/Factory.class" in the jar "/tmp/signatureFile816596119160723756.jar" has been tampered!

org.eclipse.core.runtime.CoreException: Unable to unpack artifact osgi.bundle,org.eclipse.jdt.debug.ui,3.5.0.v20100423 in repository file:/home/shared/helios/buildresults/final/aggregate: Invalid content:org/eclipse/jdt/internal/debug/ui/jres/JREsEnvironmentLabelProvider.class
Caused by: org.eclipse.osgi.signedcontent.InvalidContentException: The file "org/eclipse/jdt/internal/debug/ui/jres/JREsEnvironmentLabelProvider.class" in the jar "/tmp/signatureFile6118511218157882790.jar" has been tampered!

org.eclipse.core.runtime.CoreException: Unable to unpack artifact osgi.bundle,org.eclipse.pde.core,3.6.0.v20100429 in repository file:/home/shared/helios/buildresults/final/aggregate: Invalid content:org/eclipse/pde/internal/core/plugin/AbstractExtensionsModel.class
Caused by: org.eclipse.osgi.signedcontent.InvalidContentException: The file "org/eclipse/pde/internal/core/plugin/AbstractExtensionsModel.class" in the jar "/tmp/signatureFile6127173139783321360.jar" has been tampered!

Please note that this kind of problems will go undetected during a normal Eclipse install since p2 silently falls back to use the jar file instead.

Since this kind of errors occur from time to time, I would recommend that you add some verification to the build that really checks that he .jar.pack.gz files can be unpacked and that the result is consistent with respect to signing.

Comment 1 Kim Moir

2010-05-09 15:34:16 EDT

bug 240855 is a request to add verification.

Comment 2 Kim Moir

2010-05-17 17:14:44 EDT

I verified that versions of these pack.gz bundles aren't corrupt. (Many of our bundles were recently retagged to include source references).  

I'm going to close this as a duplicate of 240855

*** This bug has been marked as a duplicate of bug 240855 ***

Comment 3 Thomas Hallgren

2010-05-17 17:36:46 EDT

Kim, I'm fairly convinced that those packed bundles indeed are corrupt. How did you verify that they are OK?

Comment 4 Kim Moir

2010-05-17 17:50:36 EDT

I looked at the RC1 versions. I agree that the M7 ones are still corrupt but I can't fix that.

Comment 5 Thomas Hallgren

2010-05-17 17:54:14 EDT

OK. I see. I thought you could just remove them and patch the artifacts.jar manually. But with RC1 already out, I guess it's no longer a problem.