Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312175

Summary: Repository references enabled although flag says disabled.
Product: [Eclipse Project] Equinox Reporter: Thomas Hallgren <thomas>
Component: p2Assignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: david_williams, filip.hrbek, pascal
Version: 3.6Flags: pascal: review? (pascal)
susan: review+
Target Milestone: 3.6 RC1   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 312149    
Attachments:
Description Flags
Patch that fixes the condition none

Description Thomas Hallgren CLA 2010-05-09 05:00:34 EDT 
The ProvisioningContext method isEnabled(IRepositoryManager manager, IRepositoryReference reference) will always consider the referenced repository enabled regardless of its status.

The test is for (status | 1) == 1 and that will always yield true.
Comment 1 Thomas Hallgren CLA 2010-05-09 05:04:43 EDT 
Created attachment 167619 [details]
Patch that fixes the condition

This patch changes the test to (status & 1) == 1 instead of (status | 1) == 1
Comment 2 Pascal Rapicault CLA 2010-05-09 09:32:18 EDT 
Susan, I have reviewed and released, but I would appreciate if you could give an second look at this.
Comment 3 Susan McCourt CLA 2010-05-09 10:59:57 EDT 
yikes.  Thanks for catching that.