Bugzilla – Full Text Bug Listing
| Summary: | Viewers should clearly indicate whether a folder is excluded from build | ||
|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Andrew Gvozdev <angvoz.dev> |
| Component: | cdt-build | Assignee: | Andrew Gvozdev <angvoz.dev> |
| Status: | RESOLVED FIXED | QA Contact: | Andrew Gvozdev <angvoz.dev> |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | freidin.alex, malaperle, master_of_past_and_present, torkildr, yevshif |
| Version: | 7.0 | ||
| Target Milestone: | 8.0.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 195208 | ||
|
Description
Andrew Gvozdev
*** Bug 338740 has been marked as a duplicate of this bug. *** As pointed out in bug 338740, sorting should be optional and use preference introduced in bug 311880. Fixed on master and cdt_8_0. I kept the logic of decorating the same as for files. There is some irregularity in marking which I reported in bug 368115. Hi Andrew, I made a Hello world C++ project and tried to exclude the src source folder. The source folder icon went away but the it was not decorated as being excluded. Then I tried to exclude it again, it allowed me and it was decorated properly. But when I included it again, it was not a source folder anymore. I then tried a second Hello world project, with two source folders, src and src2. I excluded the src folder, same thing: no decoration and now a regular folder. Then I tried to exclude it again but it didn't allow me. Then I excluded src2, similarly, it became a regular folder and not decorated. Then I could exclude both again and see the proper decoration. After including both again, they were not source folders. Shouldn't the decoration appear the first time on a source folder? And go back to being a source folder when it's included again? I'm a bit confused on what it should do. You mention 2 separate issues, one is what is effect of "exclude" operation on the project model and another one what "excluded" decoration indicates. The implemented logic of excluded decoration - which, I admit, is not ideal - is to mark excluded files and folders under source folders only. I tried decorating non-source folders but found that it was too noisy visually and frankly unacceptable for our in-house projects. We need to define it in more consistent and user-friendly way and I suggest to discuss it further in bug 368115. *** cdt git genie on behalf of Andrew Gvozdev ***
bug 312165: Viewers should clearly indicate whether a folder is excluded
from build
Conflicts:
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/viewsupport/ExcludedFileDecorator.java
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=e62f6b43d8b36679705c14f2c78cc400fa2f30fa
*** cdt git genie on behalf of Andrew Gvozdev ***
bug 312165: Viewers should clearly indicate whether a folder is excluded
from build
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=a98cf9a89dd9ee378dfe2a716450774b245816af
*** cdt git genie on behalf of Andrew Gvozdev ***
bug 312165: Viewers should clearly indicate whether a folder is excluded
from build
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=76d3d7f2e62fb3f9560279388069e0b8203a314b
|