Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312136

Summary: Incorrect @GuardedBy comments
Product: [Eclipse Project] Platform Reporter: John Arthorne <john.arthorne>
Component: RuntimeAssignee: John Arthorne <john.arthorne>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.6   
Target Milestone: 3.8 M1   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description John Arthorne CLA 2010-05-07 17:40:21 EDT 
From Tom in bug 311756:

In my review I did notice some questionable reads and writes to the following
fields (according to the javadoc at least):

org.eclipse.core.internal.jobs.ThreadJob.isBlocked
org.eclipse.core.internal.jobs.ThreadJob.acquireRule

Both document @GuardedBy("JobManager.implicitJobs") but there are quite a few
reads and writes to these fields outside of a sync(implicitJobs) block.  I
discussed this with John briefly.  We believe the javadoc has gone a bit
overboard.  These fields should only be access by a single thread and there
should not really be any need to synchronize in that case.