Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312129

Summary: JUnit test for war import problem with class file that is not in WEB-INF/classes and has a 16 character name
Product: [WebTools] WTP Java EE Tools Reporter: Larry Isaacs <larryisaacs>
Component: jst.j2eeAssignee: Jason Sholl <jsholl>
Status: CLOSED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc, jasonpet
Version: 3.2   
Target Milestone: 3.2 RC1   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 311542    
Bug Blocks:    
Attachments:
Description Flags
Patch to add JUnit test for Bug 311542.
none
A simple war file the exercises the problem. none

Description Larry Isaacs CLA 2010-05-07 16:44:14 EDT
Created attachment 167569 [details]
Patch to add JUnit test for Bug 311542.

This is a JUnit that exercises the issue documented in Bug 311542.  I added a test311542() method to the DefectVerificationTests.  A couple of other fixes were needed as well for this particular use case to succeed.  I don't think the fixes should impact other tests.  Running the WebImportOperationTest and DefectVerificationTests show the same failures with and without the fixes.  The new test311542() test in DefectVerificationTests fails without the fix for Bug 311542 and passes with it's fix present.  Since I'm getting failures with these tests, I didn't bother running other tests.  It's not clear if this is to be expected for the current WTP 3.2, or if something is missing from my environment.

I'll attach the problem war file in a separate attachment.  The test expects to find it in the "TestData\WARImportTests" folder.  Feel free to rework the test in any way you feel is appropriate.
Comment 1 Larry Isaacs CLA 2010-05-07 16:45:19 EDT
Created attachment 167571 [details]
A simple war file the exercises the problem.
Comment 2 Carl Anderson CLA 2010-05-10 09:19:27 EDT
Jason, you owned 311542 - can you help get this JUnit in place?
Comment 3 Jason Sholl CLA 2010-05-10 13:14:17 EDT
Thanks for the JUnit; checked into head for RC1.

PMC approval is not required because this is test changes only.
Comment 4 Larry Isaacs CLA 2010-05-14 13:35:05 EDT
Verified that running the DefectVerificationTestsSuite includes a functioning test311542() test using the S-3.2.0RC1-20100513125036 wtp-tests build.
Comment 5 Jason Sholl CLA 2010-05-17 09:33:34 EDT
closing