Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312113

Summary:

Rhino debugger's prototype and protoObect are wrong

Product:

[WebTools] JSDT

Reporter:

Simon Kaegi <simon_kaegi>

Component:

Debug

Assignee:

Simon Kaegi <simon_kaegi>

Status:

RESOLVED FIXED

QA Contact:

Simon Kaegi <simon_kaegi>

Severity:

normal

Priority:

CC:

Michael_Rennie, thatnitind

Version:

3.2

Flags:

Michael_Rennie: review+

Target Milestone:

3.2 RC1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
proposed patch	none

Description Simon Kaegi

2010-05-07 14:49:41 EDT

The "protoObject" should just be the Scriptable returned from Scriptable.getProtoType(). 

The "prototype" is just a property that should generally only be on constructor functions.

Comment 1 Simon Kaegi

2010-05-07 15:29:19 EDT

Created attachment 167549 [details]
proposed patch

The protoObject is redundant. We just use the prototypeObject for the underlying (and normally hidden) prototype of the Object and the regular "prototype" property is accessed as a property.

Comment 2 Michael Rennie

2010-05-07 15:32:45 EDT

+1 super-fantastic!

Comment 3 Simon Kaegi

2010-05-09 23:12:04 EDT