Bugzilla – Full Text Bug Listing
| Summary: | Add untracked files - usability | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Technology] JGit | Reporter: | Karsten Thoms <karsten.thoms> | ||||
| Component: | JGit | Assignee: | Matthias Sohn <matthias.sohn> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | caniszczyk, matthias.sohn, remy.suen, stefan.lay | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 0.8.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
(In reply to comment #0)cked files. If I select an folder and > want to commit changes in it (see screencast), I expect to commit only > untracked files below the selected folder. Selection is currently ignored, see bug 304131. > 4) The function lists also all files in the /bin folders (see screencast). The > build directories should be excluded. It should be excluding derived files. Note that .gitignore is not being honoured, see bug 300964. (In reply to comment #0) > 1) Should the naming be "Show untracked files"? (decapitalize "Files") I'm not sure, there are many places in eclipse where nouns are capitalized (have a look e.g. at the File menu) > 2) The option should be on by default As Remy said in bug 311964, there is a discussion going on about a renewed commit dialog in bug 310128. We should discuss this question there. > 4) The function lists also all files in the /bin folders (see screencast). The > build directories should be excluded. In your example, is the bin folder set to derived? Then the files should not be shown in the dialog. (In reply to comment #2) > (In reply to comment #0) > > 1) Should the naming be "Show untracked files"? (decapitalize "Files") > I'm not sure, there are many places in eclipse where nouns are capitalized > (have a look e.g. at the File menu) The difference here is that the option is not in the menu. If you look in preference pages, the labels for checkboxes and radio buttons all use sentence case. In any case, this has always annoyed me but not enough for me to actually file a bug but it does make the whole system look unpolished. If the new dialog will not make it for 0.8, then I think this casing discrepancy should be fixed for 0.8. If it will, then this matter should just be addressed in the new dialog. pushed http://egit.eclipse.org/r/#change,755 to fix the label Merged, thanks. |
Created attachment 167509 [details] Screencast The new "Show untracked Files" option would allow to add untracked files on commit. The option is nice, but the usability could be improved. My issues are: 1) Should the naming be "Show untracked files"? (decapitalize "Files") 2) The option should be on by default 3) The option will show just any untracked files. If I select an folder and want to commit changes in it (see screencast), I expect to commit only untracked files below the selected folder. Either add a further option to limit just to selected element and below (selected by default) or do that in any case. 4) The function lists also all files in the /bin folders (see screencast). The build directories should be excluded.