Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312077

Summary:

MToolControls aren't rendered on MacOS X

Product:

[Eclipse Project] e4

Reporter:

Brian de Alwis <bsd>

Component:

Assignee:

Project Inbox <e4.ui-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

1.0

Target Milestone:

1.0 RC0

Hardware:

Macintosh

OS:

Mac OS X

Whiteboard:

Attachments:

Description	Flags
Implementation of a ToolControlRenderer	none
Wrap tool controls within a ToolItem	none
Reworked patch to support embedding in both ToolBar and Composite	none

Description Brian de Alwis

2010-05-07 10:46:38 EDT

Build: HEAD 2010/05/05 @ 7am

I was trying out to add a MToolControl to discover that WorkbenchRendererFactory is missing a tool control renderer.  Implementation to follow.

Comment 1 Brian de Alwis

2010-05-07 10:47:38 EDT

Created attachment 167487 [details]
Implementation of a ToolControlRenderer

Comment 2 Brian de Alwis

2010-05-17 13:02:09 EDT

Created attachment 168765 [details]
Wrap tool controls within a ToolItem

Follow approach defined in SWT Snippet 58 and embed the widget inside a ToolItem marked as an SWT.SEPARATOR. (http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet58.java)

Comment 3 Brian de Alwis

2010-05-17 13:03:15 EDT

Eric independently added a MToolControl renderer, but his implementation unfortunately doesn't work under MacOS X.  So I'll repurpose this bug to address the issue.

Comment 4 Brian de Alwis

2010-05-17 13:15:48 EDT

Created attachment 168767 [details]
Reworked patch to support embedding in both ToolBar and Composite

Comment 5 Eric Moffatt

2010-05-25 14:22:06 EDT

Committed in >20100525. Applied Brian's patch.