Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312075

Summary:

[ValueConverter] Use the lexer to identify valid values

Product:

[Modeling] TMF

Reporter:

Sebastian Zarnekow <sebastian.zarnekow>

Component:

Xtext

Assignee:

Project Inbox <tmf.xtext-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

sven.efftinge

Version:

1.0.0

Flags:

sebastian.zarnekow: helios+

Target Milestone:

RC1

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
Patch without regenerated noise	none
Patch with regnerated code	none

Description Sebastian Zarnekow

2010-05-07 10:45:42 EDT

Comment 1 Sebastian Zarnekow

2010-05-07 10:48:20 EDT

Created attachment 167488 [details]
Patch without regenerated noise

The patch does not change contain breaking changes in the generated. However, there was some noise after a complete regeneration that's why I attach two patches.

Comment 2 Sebastian Zarnekow

2010-05-07 10:49:13 EDT

Created attachment 167489 [details]
Patch with regnerated code

Comment 3 Sven Efftinge

2010-05-07 10:56:21 EDT

looks good

Comment 4 Sebastian Zarnekow

2010-05-07 11:00:21 EDT

Thanks for the review.

Moritz suggested to that assertNotNull() is a bad name so I'll rename it to assertValidValue() and commit the patch.

Comment 5 Sebastian Zarnekow

2010-05-07 11:22:54 EDT

Fixed in HEAD.

Comment 6 Karsten Thoms

2017-09-19 15:53:09 EDT

Closing bug which were set to RESOLVED before Eclipse Neon.0.